Skip to content

imperva_waf: improve config robustness and error reporting - #12894

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:s5694-imperva_waf
Mar 2, 2025
Merged

imperva_waf: improve config robustness and error reporting#12894
efd6 merged 1 commit into
elastic:mainfrom
efd6:s5694-imperva_waf

Conversation

@efd6

@efd6 efd6 commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

imperva_waf: improve config robustness and error reporting

* prevent missing trailing slash from causing collection failure
* avoid misleading errors resulting from collection failure

Note

The CEL input is not tested in system testing. So extra caution is required in review.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:imperva_cloud_waf Imperva Cloud WAF labels Feb 25, 2025
@efd6 efd6 self-assigned this Feb 25, 2025
* prevent missing trailing slash from causing collection failure
* avoid misleading errors resulting from collection failure
@efd6
efd6 force-pushed the s5694-imperva_waf branch from 3e445dc to 93cca24 Compare February 25, 2025 21:59
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6
efd6 marked this pull request as ready for review February 26, 2025 04:23
@efd6
efd6 requested a review from a team as a code owner February 26, 2025 04:23
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6
efd6 merged commit 0ec76df into elastic:main Mar 2, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package imperva_cloud_waf - 1.7.0 containing this change is available at https://epr.elastic.co/package/imperva_cloud_waf/1.7.0/

@mabuzenah

Copy link
Copy Markdown

im using version 1.9.0 and this part of the code is still causing an issue state.url.trim_right("/") + v.worklist[v.next].filename

{"log.level":"error","@timestamp":"2025-03-07T00:47:29.705Z","message":"single event object returned by evaluation","component":{"binary":"filebeat","dataset":"elastic_agent.filebeat","id":"cel-default","type":"cel"},"log":{"source":"cel-default"},"ecs.version":"1.6.0","input_source":"https://logs1.incapsula.com/23630_828048/","input_url":"https://logs1.incapsula.com/23630_828048/","event":{"error":{"code":"401","id":"401 Unauthorized","message":"GET https://logs1.incapsula.com/23630_82804823630_1076173.log: \r\n<title>401 Authorization Required</title>\r\n\r\n

401 Authorization Required

\r\n
nginx/1.25.0\r\n\r\n\r\n"}},"log.origin":{"file.line":383,"file.name":"cel/input.go","function":"github.com/elastic/beats/v7/x-pack/filebeat/input/cel.input.run.func1"},"service.name":"filebeat","id":"cel-imperva_cloud_waf.event-1ee7cae5-3f31-4f51-b04c-f542d4020a2e","log.logger":"input.cel","ecs.version":"1.6.0"}

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
* prevent missing trailing slash from causing collection failure
* avoid misleading errors resulting from collection failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:imperva_cloud_waf Imperva Cloud WAF Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants