Skip to content

[checkpoint] Extend key/value parsing and expand supported fields - #12929

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:enhance/checkpoint-mappings
Mar 5, 2025
Merged

[checkpoint] Extend key/value parsing and expand supported fields#12929
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:enhance/checkpoint-mappings

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Extend key/value parsing to include numbers in key names and extend supported fields.
  • Mapped checkpoint.hostname to host.hostname

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/checkpoint
elastic-package test

Related issues

- Extend key/value parsing to include numbers in key names and extend supported fields.
- Mapped checkpoint.hostname to host.hostname
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:checkpoint Check Point Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Feb 28, 2025
@taylor-swanson taylor-swanson self-assigned this Feb 28, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson
taylor-swanson marked this pull request as ready for review February 28, 2025 19:00
@taylor-swanson
taylor-swanson requested a review from a team as a code owner February 28, 2025 19:00
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@dwhyrock dwhyrock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the changelog link needs to be updated.

Comment thread packages/checkpoint/changelog.yml Outdated
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson
taylor-swanson merged commit 637377d into elastic:main Mar 5, 2025
@taylor-swanson
taylor-swanson deleted the enhance/checkpoint-mappings branch March 5, 2025 15:11
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package checkpoint - 1.38.0 containing this change is available at https://epr.elastic.co/package/checkpoint/1.38.0/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
…2929)

- Extend key/value parsing to include numbers in key names and extend supported fields.
- Mapped checkpoint.hostname to host.hostname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

3 participants