Skip to content

imperva_cloud_waf: add slash between url base and log file in second stage - #13066

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:s5733-imperva_cloud_waf
Mar 12, 2025
Merged

imperva_cloud_waf: add slash between url base and log file in second stage#13066
efd6 merged 1 commit into
elastic:mainfrom
efd6:s5733-imperva_cloud_waf

Conversation

@efd6

@efd6 efd6 commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

imperva_cloud_waf: add slash between url base and log file in second stage

When the CEL input was made more robust to user configuration, this was
forgottend. Add it now.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:imperva_cloud_waf Imperva Cloud WAF labels Mar 11, 2025
@efd6 efd6 self-assigned this Mar 11, 2025
@efd6
imperva_cloud_waf: add slash between url base and log file in second …
0996436 
…stage

When the CEL input was made more robust to user configuration, this was
forgottend. Add it now.
@efd6
efd6 force-pushed the s5733-imperva_cloud_waf branch from 7fbf418 to 0996436 Compare March 11, 2025 20:14
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elastic-sonarqube

elastic-sonarqube Bot commented Mar 11, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Mar 11, 2025

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6
@efd6
efd6 marked this pull request as ready for review March 11, 2025 20:50
@efd6
efd6 requested a review from a team as a code owner March 11, 2025 20:50
@elasticmachine

elasticmachine commented Mar 11, 2025

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
kcreddy
kcreddy reviewed Mar 12, 2025
View reviewed changes
Comment thread packages/imperva_cloud_waf/data_stream/event/agent/stream/cel.yml.hbs
(
request("GET",
state.url.trim_right("/") + v.worklist[v.next].filename
state.url.trim_right("/") + "/" + v.worklist[v.next].filename

@kcreddy kcreddy Mar 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a trim_left just in case the filename contains a forward slash?

@efd6 efd6 Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen that in the responses, and if they are deviating that much, I think we need to figure out something more solid. I would prefer to leave that until when it's needed if that ever happens.
@efd6
efd6 merged commit 0641271 into elastic:main Mar 12, 2025
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Package imperva_cloud_waf - 1.10.1 containing this change is available at https://epr.elastic.co/package/imperva_cloud_waf/1.10.1/
flexitrev pushed a commit that referenced this pull request Mar 20, 2025
@efd6 @flexitrev
imperva_cloud_waf: add slash between url base and log file in second …
b8abae7 
…stage (#13066)

When the CEL input was made more robust to user configuration, this was
forgotten. Add it now.
@github-actions github-actions Bot mentioned this pull request May 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:imperva_cloud_waf Imperva Cloud WAF Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @kcreddy