Skip to content

imperva_cloud_waf: clarify imperva file compression configuration - #13148

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:s5694-imperva_waf_docs
Mar 18, 2025
Merged

imperva_cloud_waf: clarify imperva file compression configuration#13148
efd6 merged 1 commit into
elastic:mainfrom
efd6:s5694-imperva_waf_docs

Conversation

@efd6

@efd6 efd6 commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

See title.

Apparently it is possible for people to interpret the original text as a conditional imperative rather than an imperative with an explanatory clause as is intended, resulting in incorrect configuration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:imperva_cloud_waf Imperva Cloud WAF labels Mar 17, 2025
@efd6 efd6 self-assigned this Mar 17, 2025
@efd6
efd6 force-pushed the s5694-imperva_waf_docs branch from 0e8a587 to 6e31946 Compare March 17, 2025 19:42
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

��� Build Succeeded

cc @efd6

@efd6
efd6 marked this pull request as ready for review March 17, 2025 20:53
@efd6
efd6 requested a review from a team as a code owner March 17, 2025 20:53
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chrisberkhout chrisberkhout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both look okay to me. I guess we'll see if the new one works better.

I wonder if the "Compress logs." at the start of the line is being misinterpreted. It could be "Log compression." which might be clearer for the documentation but might not match the UI anymore.

@efd6

efd6 commented Mar 18, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, I found it hard to misinterpret the original, but it was possible.

@efd6
efd6 merged commit fcccf1d into elastic:main Mar 18, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package imperva_cloud_waf - 1.10.2 containing this change is available at https://epr.elastic.co/package/imperva_cloud_waf/1.10.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:imperva_cloud_waf Imperva Cloud WAF Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants