Skip to content

[integration/system] add use_performance_counters in system integration - #13150

Merged
VihasMakwana merged 8 commits into
elastic:mainfrom
VihasMakwana:perf-counters-final
May 23, 2025
Merged

[integration/system] add use_performance_counters in system integration#13150
VihasMakwana merged 8 commits into
elastic:mainfrom
VihasMakwana:perf-counters-final

Conversation

@VihasMakwana

Copy link
Copy Markdown
Contributor

Proposed commit message

Recently, we added the ability to use performance counters to collect CPU metrics on windows. Add that option in system integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Screenshots

Screenshot 2025-01-30 at 4 23 47 PM Screenshot 2025-01-30 at 4 23 43 PM
@VihasMakwana VihasMakwana added Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Mar 18, 2025
@VihasMakwana VihasMakwana self-assigned this Mar 18, 2025
@VihasMakwana
VihasMakwana requested review from a team as code owners March 18, 2025 02:26
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
4.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Mar 18, 2025
@botelastic

botelastic Bot commented Apr 17, 2025

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Apr 17, 2025
Comment thread packages/system/changelog.yml Outdated
Comment thread packages/system/data_stream/core/manifest.yml Outdated
Comment thread packages/system/data_stream/core/manifest.yml Outdated
Comment thread packages/system/data_stream/cpu/manifest.yml Outdated
@botelastic botelastic Bot removed the Stalled label Apr 21, 2025
@ishleenk17

Copy link
Copy Markdown
Member

Also, this feature has been added from which stack version ?
Do we need to update the Kibana version for this ?

@VihasMakwana
VihasMakwana force-pushed the perf-counters-final branch from 5615185 to d436825 Compare May 4, 2025 13:18
@VihasMakwana

Copy link
Copy Markdown
Contributor Author

@ishleenk17 This feature has been added to stack. No need to update stack versions.

@VihasMakwana
VihasMakwana requested a review from ishleenk17 May 4, 2025 13:20
@VihasMakwana
VihasMakwana force-pushed the perf-counters-final branch from 31f46e0 to b6a3808 Compare May 6, 2025 12:58
@VihasMakwana
VihasMakwana requested a review from a team May 22, 2025 11:56
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @VihasMakwana

@VihasMakwana
VihasMakwana merged commit 4333961 into elastic:main May 23, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package system - 2.1.0 containing this change is available at https://epr.elastic.co/package/system/2.1.0/

v1v added a commit to v1v/integrations that referenced this pull request May 26, 2025
* main: (42 commits)
  [jamf_pro] Fix `flattened` field types for non-object values (elastic#13985)
  [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (elastic#13977)
  zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (elastic#13904)
  apm: Add config for tail-based sampling discard on write (elastic#13950)
  [CI] Add dev/coverage into backport script (elastic#13987)
  Update configuration updatecli for 8.x snapshot (elastic#13981)
  [Prometheus] Add username, password, and SSL related fields for query dataset (elastic#13969)
  o365: Ignore failures in rename processors for organization fields (elastic#13983)
  aws.firewall: Document ingested log types of AWS Network Firewall (elastic#13978)
  mimecast: resolve field data type conflicts between data streams (elastic#13825)
  [Infoblox NIOS] Handle the parsing of IPv6 address (elastic#13947)
  [Cribl] Fix handling of metric event type (elastic#13930)
  zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (elastic#13755)
  Adding agentless deployment to the sublime security integration (elastic#13963)
  [integration/system] add use_performance_counters in system integration (elastic#13150)
  crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (elastic#13955)
  [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (elastic#13959)
  github: squelch errors from pagination ends (elastic#13965)
  cisco_secure_endpoint: squelch errors from pagination ends (elastic#13964)
  [Cloud Security] Cloud Asset Inventory:  fixed cloud formation URL (elastic#13971)
  ...
v1v added a commit that referenced this pull request May 26, 2025
* feature/use-google-secrets: (43 commits)
  use -ci account
  [jamf_pro] Fix `flattened` field types for non-object values (#13985)
  [Netskope Alerts] Add text multi-field to netskope.alerts.breach.description field (#13977)
  zscaler_zia: add strict field template mode for tcp and http_endpoint input data streams (#13904)
  apm: Add config for tail-based sampling discard on write (#13950)
  [CI] Add dev/coverage into backport script (#13987)
  Update configuration updatecli for 8.x snapshot (#13981)
  [Prometheus] Add username, password, and SSL related fields for query dataset (#13969)
  o365: Ignore failures in rename processors for organization fields (#13983)
  aws.firewall: Document ingested log types of AWS Network Firewall (#13978)
  mimecast: resolve field data type conflicts between data streams (#13825)
  [Infoblox NIOS] Handle the parsing of IPv6 address (#13947)
  [Cribl] Fix handling of metric event type (#13930)
  zscaler_zpa: fix handling of multiple remote IPs, and event categorisation (#13755)
  Adding agentless deployment to the sublime security integration (#13963)
  [integration/system] add use_performance_counters in system integration (#13150)
  crowdstrike,m365_defender,microsoft_defender_{cloud,endpoint},sentinel_one: normalise severity handling (#13955)
  [forgerock] Map `forgerock.response.elapsedTime` as a long not a date (#13959)
  github: squelch errors from pagination ends (#13965)
  cisco_secure_endpoint: squelch errors from pagination ends (#13964)
  ...
anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
…on (elastic#13150)

* changelog

* changelog

* review comments

* stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

5 participants