Skip to content

[m365_defender] Add toggle button for including unknown Enum members - #13166

Merged
ShourieG merged 4 commits into
elastic:mainfrom
navnit-elastic:m365_defender-include-unknown-enum-members
Mar 20, 2025
Merged

[m365_defender] Add toggle button for including unknown Enum members#13166
ShourieG merged 4 commits into
elastic:mainfrom
navnit-elastic:m365_defender-include-unknown-enum-members

Conversation

@navnit-elastic

@navnit-elastic navnit-elastic commented Mar 19, 2025

Copy link
Copy Markdown

Proposed commit message

Provide an option to specify the Prefer: include-unknown-enum-members header for the alert data stream to handle future members in evolvable enumerations.
Enable toggle button to retrieve unknown members for properties of evolvable enum types.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/m365_defender directory.
Run the following command to run tests.
elastic-package test -v

Related issues

@navnit-elastic navnit-elastic added enhancement New feature or request Integration:m365_defender Microsoft Defender XDR Crest Contributions from Crest developement team. Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Mar 19, 2025
@navnit-elastic
navnit-elastic requested a review from a team as a code owner March 19, 2025 11:07
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Comment thread packages/m365_defender/data_stream/alert/manifest.yml Outdated
Comment thread packages/m365_defender/changelog.yml Outdated
@navnit-elastic
navnit-elastic requested a review from ShourieG March 19, 2025 12:22
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @navnit-elastic

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ShourieG
ShourieG merged commit 8f3c08e into elastic:main Mar 20, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package m365_defender - 2.25.0 containing this change is available at https://epr.elastic.co/package/m365_defender/2.25.0/

@andrewkroh andrewkroh removed the Crest Contributions from Crest developement team. label Mar 20, 2025
flexitrev pushed a commit that referenced this pull request Mar 25, 2025
…13166)

* [m365_defender] Add toggle button for including unknown enum members

* Update PR link in changelog

* Make include_unknown_enum_members optional field

---------

Co-authored-by: Navnit Chauhan <navnit.chauhan@crestdata.ai>
flexitrev pushed a commit that referenced this pull request Mar 28, 2025
…13166)

* [m365_defender] Add toggle button for including unknown enum members

* Update PR link in changelog

* Make include_unknown_enum_members optional field

---------

Co-authored-by: Navnit Chauhan <navnit.chauhan@crestdata.ai>
flexitrev pushed a commit that referenced this pull request Mar 28, 2025
…13166)

* [m365_defender] Add toggle button for including unknown enum members

* Update PR link in changelog

* Make include_unknown_enum_members optional field

---------

Co-authored-by: Navnit Chauhan <navnit.chauhan@crestdata.ai>
flexitrev pushed a commit that referenced this pull request Mar 28, 2025
…13166)

* [m365_defender] Add toggle button for including unknown enum members

* Update PR link in changelog

* Make include_unknown_enum_members optional field

---------

Co-authored-by: Navnit Chauhan <navnit.chauhan@crestdata.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:m365_defender Microsoft Defender XDR Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants