Add leader election variable in kube state metrics integration - #1321
Merged
MichaelKatsoulis merged 3 commits intoJul 13, 2021
Conversation
MichaelKatsoulis
marked this pull request as draft
July 12, 2021 16:06
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
MichaelKatsoulis
marked this pull request as ready for review
July 13, 2021 08:40
|
Pinging @elastic/integrations (Team:Integrations) |
ChrsMark
approved these changes
Jul 13, 2021
ChrsMark
left a comment
Member
There was a problem hiding this comment.
Great enhancement, feel free to ship it!
Some partially related comments:
- Testing notes are really good (+ scripts etc), maybe we can document them somewhere for the future. @MichaelKatsoulis could you take care of this?
- With this condition added the only missing part from standlone version is the conditions so as to run control-plane's module only on master using autodiscovery. See https://github.com/elastic/beats/blob/master/deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml#L347. @MichaelKatsoulis it would be nice to have a follow-up PR/issue for this.
In general this managed version of k8s integration which more or less stands equally next to the standalone version sounds like a good demo candidate.
Contributor
Author
|
Thanks @ChrsMark !
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What does this PR do?
It adds an extra setting
leaderelection: trueto the kubernetes package in data_streams that collect cluster wise metrics (kube_state*, apiserver, events) so as to indicate that that these specific data_streams should be enabled only when leadership lock is obtained.Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.13.0).How to test this PR locally
elastic-package buildinsideintegrations/packages/kubernetesfolderelastic-package stack up --version=7.14.0-SNAPSHOT -v -dLeader Electionactivated. Copy the enrolment token of the new policy.FLEET_URL:"http://fleet-server:8220",FLEET_ENROLLMENT_TOKEN:token from step 5and apply the manifestskubectl apply -f .metricset=state_pod) come from only oneagent.namewhich is the leaderRelated issues
Screenshots