Skip to content

[netflow] Expand the tcp_control_bits into the relevant flag names - #13307

Merged
jrmolin merged 5 commits into
elastic:mainfrom
jrmolin:netflow-break_out_tcp_flags
May 7, 2025
Merged

[netflow] Expand the tcp_control_bits into the relevant flag names#13307
jrmolin merged 5 commits into
elastic:mainfrom
jrmolin:netflow-break_out_tcp_flags

Conversation

@jrmolin

@jrmolin jrmolin commented Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

[netflow] Expand the tcp_control_bits into the relevant TCP flag names

  • Added a Painless script to walk the bit-set to translate to an array of strings
  • Verified by hand during development
  • No regressions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@jrmolin jrmolin added enhancement New feature or request Integration:netflow NetFlow Records labels Mar 25, 2025
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@jrmolin
jrmolin marked this pull request as ready for review March 26, 2025 12:06
@jrmolin
jrmolin requested a review from a team as a code owner March 26, 2025 12:06
@andrewkroh andrewkroh added the Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Mar 26, 2025
@elasticmachine

elasticmachine commented Mar 26, 2025

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)
andrewkroh
andrewkroh reviewed Apr 1, 2025
View reviewed changes
Comment thread packages/netflow/data_stream/log/fields/package-fields.yml
Comment thread packages/netflow/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/netflow/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Comment thread packages/netflow/changelog.yml Outdated
@jrmolin
jrmolin requested a review from andrewkroh May 6, 2025 19:47
andrewkroh
andrewkroh reviewed May 6, 2025
View reviewed changes
Comment thread packages/netflow/data_stream/log/fields/package-fields.yml Outdated
@jrmolin
jrmolin requested a review from andrewkroh May 7, 2025 11:57
@elasticmachine

elasticmachine commented May 7, 2025

Copy link
Copy Markdown

💚 Build Succeeded

History
@elastic-sonarqube

elastic-sonarqube Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@jrmolin
jrmolin merged commit e7fe95b into elastic:main May 7, 2025
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Package netflow - 2.23.0 containing this change is available at https://epr.elastic.co/package/netflow/2.23.0/
@jrmolin
jrmolin deleted the netflow-break_out_tcp_flags branch May 7, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:netflow NetFlow Records Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

4 participants

@jrmolin @elasticmachine @andrewkroh @taylor-swanson