[watchguard_firebox] Fix parsing errors - #13324
Merged
Merged
Conversation
Fix two parsing errors that have been observed by users of this integration: * Hostnames with underscore were not being parsed * When port '0' is used in a message, community_id processor was failing to parse the message.
andrewkroh
added
Integration:watchguard_firebox
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
mjwolf
enabled auto-merge (squash)
March 27, 2025 16:33
Contributor
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
reviewed
Apr 1, 2025
mjwolf
disabled auto-merge
April 3, 2025 21:06
mjwolf
enabled auto-merge (squash)
April 4, 2025 00:28
taylor-swanson
left a comment
taylor-swanson
left a comment
Contributor
There was a problem hiding this comment.
I'm debating if this should be considered a breaking change or not. We are changing how the fields look, but I also think that elasticsearch treats an array of a single element and value as effectively the same thing, so perhaps it's not an issue?
💚 Build Succeeded
History
|
|
taylor-swanson
approved these changes
Apr 28, 2025
Contributor
|
Package watchguard_firebox - 1.3.1 containing this change is available at https://epr.elastic.co/package/watchguard_firebox/1.3.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fix two parsing errors that have been observed by users of this integration:
source.ip,destination.ip,source.portandsource.destinationto comply with ECS properlyChecklist
changelog.ymlfile.[ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesRelated issues