m365_defender,sentinel_one_cloud_funnel: improve command line split script performance - #13335
Merged
efd6 merged 1 commit intoMar 30, 2025
Conversation
efd6
added
enhancement
…cript performance Investigation in the crowdstrike fdr data stream has shown that this processor can be significantly improved in terms of performance by reducing string allocation while tokenising the command line. This change replays the changes in that data stream in m365_defender and sentinel_one_cloud_funnel. ref: elastic#13325
efd6
force-pushed
the
cmdline_perf-sentinel_one_cloud_funnel-m365_defender
branch
from
March 27, 2025 21:48
33b4a88 to
6a5ec54
Compare
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
alert |
0 | 759.3 | 759.3 ( - %) | 👍 |
event |
0 | 612.37 | 612.37 ( - %) | 👍 |
incident |
0 | 893.66 | 893.66 ( - %) | 👍 |
Package sentinel_one_cloud_funnel 👍(1) 💚(0) 💔(0)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
event |
0 | 361.27 | 361.27 ( - %) | 👍 |
efd6
marked this pull request as ready for review
March 27, 2025 22:23
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
/test benchmark fullreport |
|
💚 Build Succeeded
History
cc @efd6 |
kcreddy
approved these changes
Mar 28, 2025
Contributor
|
Package m365_defender - 3.1.0 containing this change is available at https://epr.elastic.co/package/m365_defender/3.1.0/ |
Contributor
|
Package sentinel_one_cloud_funnel - 1.11.0 containing this change is available at https://epr.elastic.co/package/sentinel_one_cloud_funnel/1.11.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots