[crowdstrike, microsoft_defender_endpoint, sentinel_one] Update host.* ECS mappings - #13373
Merged
efd6 merged 7 commits intoApr 10, 2025
Conversation
brijesh-elastic
added
enhancement
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
falcon |
7518.8 | 5714.29 | -1804.51 (-24%) | 💔 |
Package sentinel_one 👍(2) 💚(0) 💔(3)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
agent |
3378.38 | 2057.61 | -1320.77 (-39.09%) | 💔 |
alert |
3236.25 | 2457 | -779.25 (-24.08%) | 💔 |
group |
35714.29 | 29411.76 | -6302.53 (-17.65%) | 💔 |
To see the full report comment with /test benchmark fullreport
efd6
reviewed
Apr 6, 2025
| - android | ||
| source: | | ||
| for (String os: params.os_type) { | ||
| if (ctx.crowdstrike.vulnerability.host_info.platform.toLowerCase().contains(os)) { |
Contributor
There was a problem hiding this comment.
Map look-up or case-folded equality? If not, hoist the string construction outside the loop.
Contributor
There was a problem hiding this comment.
Please hoist the string construction out of the loop.
String platform = ctx.crowdstrike.vulnerability.host_info.platform.toLowerCase();
for (String os: params.os_type) {
Comment on lines
+443
to
+445
| if (ctx.host.os.family.toLowerCase().contains(os)) { | ||
| ctx.host.os.put('type', os); | ||
| } |
Comment on lines
+635
to
+640
| if (ctx.host == null) { | ||
| ctx.put('host', new HashMap()); | ||
| } | ||
| if (ctx.host.os == null) { | ||
| ctx.host.put('os', new HashMap()); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (ctx.host == null) { | |
| ctx.put('host', new HashMap()); | |
| } | |
| if (ctx.host.os == null) { | |
| ctx.host.put('os', new HashMap()); | |
| } | |
| ctx.host = ctx.host ?: [:]; | |
| ctx.host.os = ctx.host.os ?: [:]; |
Comment on lines
+642
to
+644
| if (ctx.json.osType.toLowerCase().contains(os)) { | ||
| ctx.host.os.put('type', os); | ||
| } |
Contributor
There was a problem hiding this comment.
Map look-up or case-folded equality? Otherwise hoist string construction.
Comment on lines
+149
to
+159
| if (ctx.host == null) { | ||
| ctx.put('host', new HashMap()); | ||
| } | ||
| if (ctx.host.os == null) { | ||
| ctx.host.put('os', new HashMap()); | ||
| } | ||
| for (String os: params.os_type) { | ||
| if (ctx.sentinel_one.alert.agent.os.type.toLowerCase().contains(os)) { | ||
| ctx.host.os.put('type', os); | ||
| } | ||
| } |
Comment on lines
+371
to
+381
| if (ctx.host == null) { | ||
| ctx.put('host', new HashMap()); | ||
| } | ||
| if (ctx.host.os == null) { | ||
| ctx.host.put('os', new HashMap()); | ||
| } | ||
| for (String os: params.os_type) { | ||
| if (ctx.json.agentRealtimeInfo.agentOsType.toLowerCase().contains(os)) { | ||
| ctx.host.os.put('type', os); | ||
| } | ||
| } |
…endpoint-sentinel_one
…endpoint-sentinel_one
|
💚 Build Succeeded
History
|
Contributor
|
Package crowdstrike - 1.63.0 containing this change is available at https://epr.elastic.co/package/crowdstrike/1.63.0/ |
Contributor
|
Package microsoft_defender_endpoint - 2.32.0 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/2.32.0/ |
Contributor
|
Package sentinel_one - 1.33.0 containing this change is available at https://epr.elastic.co/package/sentinel_one/1.33.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
To improve bidirectional response actions, maintain consistent
host.*mappings for CrowdStrike, SentinelOne, and Microsoft Defender for Endpoint packages.All three integrations will provide
host.id(which will be used for sending action requests to the EDR platform) andhost.os.typevalues.Checklist
changelog.ymlfile.Author's Checklist
Related issues