Skip to content

okta: retain full email address as user.name - #13404

Merged
efd6 merged 4 commits into
elastic:mainfrom
efd6:st11882-okta
Apr 7, 2025
Merged

okta: retain full email address as user.name#13404
efd6 merged 4 commits into
elastic:mainfrom
efd6:st11882-okta

Conversation

@efd6

@efd6 efd6 commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

okta: retain full email address as user.name

The entityanalytics_okta integration retains the full email address
rather than only the username part of the address. This breaks being
able to correlate individual entities with events, in addition to
potentially allowing collision between non-identitical users in events.
So simplify the code and just keep the whole thing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 3, 2025
@efd6 efd6 self-assigned this Apr 3, 2025
The entityanalytics_okta integration retains the full email address
rather than only the username part of the address. This breaks being
able to correlate individual entities with events, in addition to
potentially allowing collision between non-identitical users in events.
So simplify the code and just keep the whole thing.
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package okta 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
system 1265.82 1028.81 -237.01 (-18.72%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

��� Build Succeeded

cc @efd6

@efd6
efd6 marked this pull request as ready for review April 3, 2025 03:21
@efd6
efd6 requested a review from a team as a code owner April 3, 2025 03:21
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6
efd6 merged commit 8675302 into elastic:main Apr 7, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package okta - 3.6.0 containing this change is available at https://epr.elastic.co/package/okta/3.6.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants