Skip to content

[cisco_ise] Add Support of Timezone Configuration Parameter - #13540

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
mohitjha-elastic:cisco_ise-1.27.0
Apr 24, 2025
Merged

[cisco_ise] Add Support of Timezone Configuration Parameter#13540
taylor-swanson merged 2 commits into
elastic:mainfrom
mohitjha-elastic:cisco_ise-1.27.0

Conversation

@mohitjha-elastic

@mohitjha-elastic mohitjha-elastic commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Proposed Commit Message

cisco_ise: add support for timezone offset in configuration parameter of all the input types.

This adds support for the timezone offset as a configuration parameter in all the three input types to adjust
the timezone when importing logs from a host in a different timezone so that datetimes are
appropriately interpreted.

This change has been tested on the data available in the test folder.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/cisco_ise directory.
Run the following command to run tests.
elastic-package test -v

Related issues

It closes issue #24307 from the enhancements repo.

@mohitjha-elastic mohitjha-elastic added enhancement New feature or request Integration:cisco_ise Cisco ISE Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Apr 15, 2025
@mohitjha-elastic mohitjha-elastic self-assigned this Apr 15, 2025
@mohitjha-elastic
mohitjha-elastic requested a review from a team as a code owner April 15, 2025 05:59
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Apr 15, 2025
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Comment thread packages/cisco_ise/changelog.yml Outdated
Comment thread packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
1. Update changelog entry.
2. Update syslog timezone priority.
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mohitjha-elastic

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy

kcreddy commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

@taylor-swanson feel free to merge the PR as @mohitjha-elastic doesn't have access to merge. Thank you!

@taylor-swanson
taylor-swanson merged commit 74f6cfa into elastic:main Apr 24, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.27.0 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.27.0/

@mohitjha-elastic
mohitjha-elastic deleted the cisco_ise-1.27.0 branch May 15, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_ise Cisco ISE Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants