gcp: remove never-successful violation field renames - #13777
Merged
Conversation
efd6
added
Integration:gcp
Contributor
🚀 Benchmarks reportTo see the full report comment with |
efd6
marked this pull request as ready for review
May 4, 2025 22:11
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chrisberkhout
approved these changes
May 21, 2025
chrisberkhout
left a comment
chrisberkhout
left a comment
Contributor
There was a problem hiding this comment.
Not renames absent fields seems fine.
Not adding renames to change the case of actual fields seems fine since they're already provided and documented in the current form.
The rename refers to fields that do not exist in the type, and appears to
have been incorrectly added to the block handling PolicyViolationInfo.
The alternative would have been to add the following, but we already
document the current behaviour, so leaving this as is as unfortunate.
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.errorMessage
target_field: _ingest._value.error_message
if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.checkedValue
target_field: _ingest._value.checked_value
if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.policyType
target_field: _ingest._value.policy_type
if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List
[1]https://cloud.google.com/logging/docs/reference/audit/auditlog/rest/Shared.Types/AuditLog#ViolationInfo
efd6
enabled auto-merge (squash)
May 21, 2025 21:15
💚 Build Succeeded
History
cc @efd6 |
|
Contributor
|
Package gcp - 2.42.1 containing this change is available at https://epr.elastic.co/package/gcp/2.42.1/ |
anupratharamachandran
pushed a commit
to anupratharamachandran/integrations
that referenced
this pull request
Jun 2, 2025
The rename refers to fields that do not exist in the type, and appears to
have been incorrectly added to the block handling PolicyViolationInfo.
The alternative would have been to add the following, but we already
document the current behaviour, so leaving this as is as unfortunate.
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.errorMessage
target_field: _ingest._value.error_message
if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.checkedValue
target_field: _ingest._value.checked_value
if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.policyType
target_field: _ingest._value.policy_type
if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List
[1]https://cloud.google.com/logging/docs/reference/audit/auditlog/rest/Shared.Types/AuditLog#ViolationInfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Thanks to @ishleenk17 for identifying this.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots