Add Cluster filter on Kubernetes Overview dashboard - #1413
Merged
ChrsMark merged 4 commits intoAug 4, 2021
Conversation
akshay-saraswat
added
bug
|
Pinging @elastic/integrations (Team:Integrations) |
💔 Build Failed
Expand to view the summary
Build stats
Trends 🧪Steps errors
Expand to view the steps failures
|
ChrsMark
requested changes
Aug 2, 2021
ChrsMark
left a comment
ChrsMark
left a comment
Member
There was a problem hiding this comment.
Thanks for submitting this. I left some comments. Also I think that we miss the updated screenshot for the docs.
Member
There was a problem hiding this comment.
Are these backslashes intentional?
Author
There was a problem hiding this comment.
These changes were generated by the elastic-package build. Don't know why these are required.
Author
There was a problem hiding this comment.
I ran elastic-package build after elastic-package format and don't see this change introduced anymore.
Contributor
There was a problem hiding this comment.
Yes, this escaping is needed to properly visualize them in READMEs (potential conflict with italics ).
Contributor
|
@akshay-saraswat thanks for this. I think you should run |
Author
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Author
|
Ran following commands in package/kubernetes
Added a screenshot too to the updated commit. |
ChrsMark
reviewed
Aug 3, 2021
ChrsMark
left a comment
ChrsMark
left a comment
Member
There was a problem hiding this comment.
Only one addition is needed, but overall it looks good to me.
Member
|
Tests seem to fail to due to format failures: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-1413/5/pipeline |
Author
|
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Member
|
@mtojek tests seem to fail in CI while locally |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
approved these changes
Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a Cluster name selector on the [Metrics Kubernetes] Overview dashboard. This selector will be used as a filter for the dashboard. Also, added a blurb for this selector on the Kubernetes package guide to explain how this selector works and where it sources the data from.
Why is it important?
We have added a new Cluster name field in the Kubernetes package. This field will not be useful unless users could discover it in some form
in UI.
Checklist
changelog.ymlfile.