keycloak: allow ISO8601 datetime format - #14191
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
efd6
left a comment
There was a problem hiding this comment.
Is there a test for this and a demonstrated need?
|
I didn't add a test as I didn't find an official Keycloak doc of the supported date format, but we tested it internally for our instances. If necessary, I'm perfectly fine with adding a test-case. Context: We use RHSSO, there are frequent parsing errors because of the date format, as it somehow uses ISO-like format without timezone offset. As this change should be only beneficial as multiple date formats are supported and checked sequentially by the processor, this would fix these issues. We might be able to change the log timestamp, however, I think it would be more beneficial to support proprietary distributions of Keycloak as well. |
|
Thanks. Please add a test. |
|
@efd6 Test case has been added. Please run CI again. |
efd6
left a comment
There was a problem hiding this comment.
I suspect that you are using and older version of elastic-package. Can you update that to the most recent release and redo elastic-package test pipeline -g?
|
/test |
…Alphayeeeet/integrations into keycloak-add-isodatetime-format
|
@efd6 Version was updated, however there were no significant changes in the expected test results. |
|
/test |
|
Thanks. The change I was expecting was made. |
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
|
@efd6 Has been fixed |
|
/test |
💚 Build Succeeded
History
|
|
|
Package keycloak - 1.29.0 containing this change is available at https://epr.elastic.co/package/keycloak/1.29.0/ |




Please label as enhancement
The officially as-well supported ISO8601 timestamp shall be added to the date processor.