Skip to content

keycloak: allow ISO8601 datetime format - #14191

Merged
efd6 merged 12 commits into
elastic:mainfrom
Alphayeeeet:keycloak-add-isodatetime-format
Jun 18, 2025
Merged

keycloak: allow ISO8601 datetime format#14191
efd6 merged 12 commits into
elastic:mainfrom
Alphayeeeet:keycloak-add-isodatetime-format

Conversation

@Alphayeeeet

Copy link
Copy Markdown
Contributor

Please label as enhancement

The officially as-well supported ISO8601 timestamp shall be added to the date processor.

@Alphayeeeet
Alphayeeeet requested a review from a team as a code owner June 10, 2025 08:53
@andrewkroh andrewkroh added Integration:keycloak Keycloak Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 10, 2025
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6

efd6 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

/test

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test for this and a demonstrated need?

@efd6 efd6 changed the title Allow ISO8601 datetime format Jun 10, 2025
@Alphayeeeet

Copy link
Copy Markdown
Contributor Author

I didn't add a test as I didn't find an official Keycloak doc of the supported date format, but we tested it internally for our instances. If necessary, I'm perfectly fine with adding a test-case.

Context: We use RHSSO, there are frequent parsing errors because of the date format, as it somehow uses ISO-like format without timezone offset. As this change should be only beneficial as multiple date formats are supported and checked sequentially by the processor, this would fix these issues.

We might be able to change the log timestamp, however, I think it would be more beneficial to support proprietary distributions of Keycloak as well.

@efd6

efd6 commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

Thanks. Please add a test.

@Alphayeeeet

Copy link
Copy Markdown
Contributor Author

@efd6 Test case has been added. Please run CI again.

@Alphayeeeet
Alphayeeeet requested a review from efd6 June 13, 2025 07:41

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that you are using and older version of elastic-package. Can you update that to the most recent release and redo elastic-package test pipeline -g?

@efd6

efd6 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

/test

@Alphayeeeet

Alphayeeeet commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

@efd6 Version was updated, however there were no significant changes in the expected test results.
Please run CI again and approve if applicable. Thanks

@Alphayeeeet
Alphayeeeet requested a review from efd6 June 13, 2025 08:25
@efd6

efd6 commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

/test

@efd6

efd6 commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

Thanks. The change I was expecting was made.

Comment thread packages/keycloak/changelog.yml Outdated
Comment thread packages/keycloak/manifest.yml Outdated
Alphayeeeet and others added 2 commits June 18, 2025 13:13
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@Alphayeeeet

Copy link
Copy Markdown
Contributor Author

@efd6 Has been fixed

@Alphayeeeet
Alphayeeeet requested a review from efd6 June 18, 2025 11:13
@efd6

efd6 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6
efd6 merged commit c17a47c into elastic:main Jun 18, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package keycloak - 1.29.0 containing this change is available at https://epr.elastic.co/package/keycloak/1.29.0/

shmsr pushed a commit to shmsr/integrations that referenced this pull request Jun 30, 2025
@Alphayeeeet
Alphayeeeet deleted the keycloak-add-isodatetime-format branch July 14, 2025 06:30
@andrewkroh andrewkroh added the enhancement New feature or request label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:keycloak Keycloak Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants