Skip to content

[sql_input] Update manifest format_version to 3.* - #14266

Merged
mykola-elastic merged 12 commits into
elastic:mainfrom
mykola-elastic:sql_input_manifest_version_update
Jun 27, 2025
Merged

[sql_input] Update manifest format_version to 3.*#14266
mykola-elastic merged 12 commits into
elastic:mainfrom
mykola-elastic:sql_input_manifest_version_update

Conversation

@mykola-elastic

@mykola-elastic mykola-elastic commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

See title

  • Change format_version to 3.3.2
  • Change the type of metrics.* from object to keyword (we cannot have type: object without object_type: ... in format_version 3.*)
  • Change system tests and sample_event.json to always have/return strings (varchar) in metrics.* (to match keyword type)

The type of metrics.* doesn't matter much because it is the responsibility of the user to define custom mappings. metrics.* only exists for system tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@mykola-elastic mykola-elastic self-assigned this Jun 19, 2025
@mykola-elastic mykola-elastic added enhancement New feature or request Integration:sql SQL Input labels Jun 19, 2025
@mykola-elastic
mykola-elastic force-pushed the sql_input_manifest_version_update branch from 3e9a0b7 to 52793e1 Compare June 20, 2025 08:03
@mykola-elastic
mykola-elastic marked this pull request as ready for review June 20, 2025 12:34
@mykola-elastic
mykola-elastic requested a review from a team as a code owner June 20, 2025 12:34
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Jun 20, 2025
Comment thread packages/sql_input/sample_event.json Outdated
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mykola-elastic

@mykola-elastic
mykola-elastic merged commit 9777117 into elastic:main Jun 27, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package sql - 0.8.0 containing this change is available at https://epr.elastic.co/package/sql/0.8.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:sql SQL Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

4 participants