amazon_security_lake: remove incoming null fields - #14392
Merged
Conversation
efd6
added
bugfix
It seems that the conventional approach to tesing for the presence of fields is inadequately safe; if a field is null but present, the test over optimistically allows potentially sensitive processors, such as rename, to fail. So remove all null fields on entry.
efd6
force-pushed
the
s6140-amazon_security_lake
branch
from
July 2, 2025 07:10
d573158 to
da66670
Compare
Contributor
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
cc @efd6 |
efd6
marked this pull request as ready for review
July 2, 2025 07:56
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
Package amazon_security_lake - 2.5.3 containing this change is available at https://epr.elastic.co/package/amazon_security_lake/2.5.3/ |
robester0403
pushed a commit
to robester0403/integrations
that referenced
this pull request
Jul 8, 2025
It seems that the conventional approach to tesing for the presence of fields is inadequately safe; if a field is null but present, the test over optimistically allows potentially sensitive processors, such as rename, to fail. So remove all null fields on entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots