fix(m365_defender): propagate state variables on error - #14722
Conversation
StacieClark-Elastic
added
Integration:m365_defender
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
fb352df to
42f4f61
Compare
a261c20 to
7ad062a
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
vulnerability |
2145.92 | 1730.1 | -415.82 (-19.38%) | 💔 |
To see the full report comment with /test benchmark fullreport
chrisberkhout
left a comment
chrisberkhout
left a comment
There was a problem hiding this comment.
Looks good. Some suggestions about closing things at the level of indentation at which they were opened.
| } | ||
| ) |
There was a problem hiding this comment.
| } | |
| ) | |
| }) |
Avoids a half indentation and make it clearer that the following ) closes the .as( in line 63.
There was a problem hiding this comment.
I used celfmt on the entire file. It won't allow ({ or }). This causes some changes on lines that weren't changed but it follows the convention that celfmt sets.
There was a problem hiding this comment.
Yes, celfmt doesn't have the best taste, but it has simple taste. These no longer cuddle.
| } | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I used celfmt on the entire file. It won't allow ({ or }). This causes some changes on lines that weren't changed but it follows the convention that celfmt sets.
| } | ||
| ) |
There was a problem hiding this comment.
| } | |
| ) | |
| }) |
And here.
There was a problem hiding this comment.
I used celfmt on the entire file. It won't allow ({ or }). This causes some changes on lines that weren't changed but it follows the convention that celfmt sets.
Enhanced error handling in the CEL program to prevent 'no such key: product_batch_size' errors by ensuring proper propagation of the state data configuration during failures. This was accomplished by wrapping the objects returned from errors with state.with()
Added correct PR number
e52a839 to
a46530c
Compare
…am with state.with() instead of wrapping each error event with state.with()
|
💚 Build Succeeded
History
|
|
Package m365_defender - 3.14.0 containing this change is available at https://epr.elastic.co/package/m365_defender/3.14.0/ |
5 participants
Proposed commit message
Enhanced error handling in the CEL program to prevent "no such key: product_batch_size'" errors by ensuring proper propagation of the state data configuration during failures. This was accomplished by wrapping the objects returned from errors with state.with()
Checklist
changelog.ymlfile.