Skip to content

m365_defender,microsoft_defender_endpoint: gracefully handle empty nested IP values - #14857

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:s6275-m365_defender-defender_for_endpoint
Aug 8, 2025
Merged

m365_defender,microsoft_defender_endpoint: gracefully handle empty nested IP values#14857
efd6 merged 1 commit into
elastic:mainfrom
efd6:s6275-m365_defender-defender_for_endpoint

Conversation

@efd6

@efd6 efd6 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

m365_defender,microsoft_defender_endpoint: gracefully handle empty nested IP values

It seems that the endpoint will send IP values that are an empty string.
To work around the absence of a condition on processors in a foreach
processors, just remove all empty strings under the affected fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Aug 7, 2025
@efd6 efd6 added Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:m365_defender Microsoft Defender XDR bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 7, 2025
…sted IP values

It seems that the endpoint will send IP values that are an empty string.
To work around the absence of a condition on processors in a foreach
processors, just remove all empty strings under the affected fields.
@efd6
efd6 force-pushed the s6275-m365_defender-defender_for_endpoint branch from 8593425 to 1773e34 Compare August 7, 2025 21:28
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6
efd6 marked this pull request as ready for review August 7, 2025 22:23
@efd6
efd6 requested a review from a team as a code owner August 7, 2025 22:23
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 changed the title m365_defender,microsoft_defender_endpoint: gracefully handle empty ne… Aug 8, 2025
@efd6
efd6 merged commit 80066f5 into elastic:main Aug 8, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package m365_defender - 3.14.2 containing this change is available at https://epr.elastic.co/package/m365_defender/3.14.2/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package microsoft_defender_endpoint - 2.42.2 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/2.42.2/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
…sted IP values (elastic#14857)

It seems that the endpoint will send IP values that are an empty string.
To work around the absence of a condition on processors in a foreach
processors, just remove all empty strings under the affected fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:m365_defender Microsoft Defender XDR Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants