Skip to content

[elastic_security] Add Support for Conditional Required Fields to Handle the Auth Type - #15253

Merged
mohitjha-elastic merged 3 commits into
elastic:mainfrom
mohitjha-elastic:elastic_security-0.4.0
Sep 11, 2025
Merged

[elastic_security] Add Support for Conditional Required Fields to Handle the Auth Type#15253
mohitjha-elastic merged 3 commits into
elastic:mainfrom
mohitjha-elastic:elastic_security-0.4.0

Conversation

@mohitjha-elastic

@mohitjha-elastic mohitjha-elastic commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

elastic_security: add support for conditional required fields to handle the auth type.

This update introduces support for conditional required fields in the elastic_security integration 
to better handle different authentication types.
Added logic to dynamically enforce required fields based on the selected auth_type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install the elastic package locally.
  • Start the elastic stack using the elastic package.
  • Move to integrations/packages/elastic_security directory.
  • Run the following command to run tests.

elastic-package test -v

Related issues

elastic_security-ss
@mohitjha-elastic mohitjha-elastic self-assigned this Sep 9, 2025
@mohitjha-elastic mohitjha-elastic added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Integration:elastic_security Elastic Security labels Sep 9, 2025
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@mohitjha-elastic
mohitjha-elastic marked this pull request as ready for review September 9, 2025 12:20
@mohitjha-elastic
mohitjha-elastic requested a review from a team as a code owner September 9, 2025 12:20
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Comment on lines +9 to +12
api_key:
- name: auth_type
value: api_auth
- name: api_key

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
api_key:
- name: auth_type
value: api_auth
- name: api_key
api_auth:
- name: auth_type
value: api_auth
- name: api_key
Comment thread packages/elastic_security/data_stream/alert/manifest.yml

@chrisberkhout chrisberkhout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the proposed commit message, please use "package" or "integration" instead of "module", because modules are different.

Modules have some of the functionality of integrations but in they are included directly inside Auditbeat/Filebeat/Metricbeat/Winlogbeat instead of being managed by Elastic Agent.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mohitjha-elastic

@mohitjha-elastic
mohitjha-elastic merged commit b10fbe7 into elastic:main Sep 11, 2025
9 checks passed
@mohitjha-elastic
mohitjha-elastic deleted the elastic_security-0.4.0 branch September 11, 2025 07:30
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package elastic_security - 0.4.0 containing this change is available at https://epr.elastic.co/package/elastic_security/0.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:elastic_security Elastic Security Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants