[vsphere] add extra grok pattern to cover more log formats - #15274
Merged
Conversation
stefans-elastic
added
enhancement
Contributor
🚀 Benchmarks reportTo see the full report comment with |
giorgi-imerlishvili-elastic
self-requested a review
September 11, 2025 06:14
giorgi-imerlishvili-elastic
approved these changes
Sep 11, 2025
💚 Build Succeeded
History
|
|
Member
|
Can we create an issue which type of log aptterns are we creating here. And lonk the issue to this for claruty @stefans-elastic |
Contributor
Author
updated the parent issue |
mykola-elastic
approved these changes
Sep 12, 2025
ishleenk17
reviewed
Sep 16, 2025
| (%{POSINT:process.pid:long}|-) - -%{SPACE}%{GREEDYDATA:message}" | ||
| - "^(%{ECS_SYSLOG_PRIORITY})?%{TIMESTAMP_ISO8601:_tmp.timestamp}%{SPACE}%{HOST}%{SPACE}%{DATA:process.name}(?:\\[%{POSINT:process.pid:long}\\])?\\: | ||
| %{GREEDYDATA:message}" | ||
| - "^(%{ECS_SYSLOG_PRIORITY})?%{TIMESTAMP_ISO8601:_tmp.timestamp}%{SPACE}%{HOST}%{SPACE}%{NOTSPACE:process.name}%{SPACE}(%{POSINT:process.pid:long}|-)( -)?%{SPACE}%{GREEDYDATA:message}" |
Member
There was a problem hiding this comment.
- Any specififc reason for using {NOTSPACE:process.name} instead of {DATA:process.name} ?
- Have we officially verified that vSphere logs can have process id without [ ] ?
Contributor
Author
There was a problem hiding this comment.
- No. Its just what I've found sooner (somehow).
- These patterns came up from a customer issue so I think - yes.
ishleenk17
approved these changes
Sep 16, 2025
Contributor
|
Package vsphere - 1.22.0 containing this change is available at https://epr.elastic.co/package/vsphere/1.22.0/ |
tehbooom
pushed a commit
to tehbooom/integrations
that referenced
this pull request
Nov 19, 2025
…5274) * [vsphere] add extra grok pattern to cover more log formats * pattern cleanup * Update packages/vsphere/changelog.yml --------- Co-authored-by: Mykola Kmet <mykola.kmet@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots