feat: improve s3 access log parsing along with documentation updates - #15309
Merged
Kavindu-Dodan merged 2 commits intoSep 15, 2025
Merged
Conversation
Kavindu-Dodan
force-pushed
the
feat/improve-firehose-access-log-parsing
branch
from
September 12, 2025 18:11
138fa37 to
40313af
Compare
andrewkroh
added
documentation
kaiyan-sheng
approved these changes
Sep 15, 2025
kaiyan-sheng
left a comment
kaiyan-sheng
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the clarification in the documentation!
gizas
reviewed
Sep 15, 2025
| return; | ||
| } | ||
|
|
||
| // Check for operation field content. Refer - https://docs.aws.amazon.com/AmazonS3/latest/userguide/LogFormat.html#log-record-fields |
Contributor
There was a problem hiding this comment.
Suggested change
| // Check for operation field content. Refer - https://docs.aws.amazon.com/AmazonS3/latest/userguide/LogFormat.html#log-record-fields | |
| // Check for Operation field content. Refer - https://docs.aws.amazon.com/AmazonS3/latest/userguide/LogFormat.html#log-record-fields |
gizas
reviewed
Sep 15, 2025
| def tokenCount = tokens.length; | ||
|
|
||
| // Check for S3 Access logs first using a more reliable token count | ||
| // Check for S3 Access logs first using a more reliable token content check |
Contributor
There was a problem hiding this comment.
nit : this comment not needed at all I think
Contributor
Author
There was a problem hiding this comment.
Good point, I improved this comment only to show what it does - 5d35266
gizas
approved these changes
Sep 15, 2025
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Kavindu-Dodan
force-pushed
the
feat/improve-firehose-access-log-parsing
branch
from
September 15, 2025 15:53
5d35266 to
d5c5ce9
Compare
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
Contributor
|
Package awsfirehose - 1.9.0 containing this change is available at https://epr.elastic.co/package/awsfirehose/1.9.0/ |
tehbooom
pushed a commit
to tehbooom/integrations
that referenced
this pull request
Nov 19, 2025
…lastic#15309) * feat: improve s3 access log parsing along with documentation updates Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * review changes Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues
Fixes #15157
Screenshots
Improved documentation to highlight firehose integration only need asset intallation,
Footnotes
https://docs.aws.amazon.com/AmazonS3/latest/userguide/LogFormat.html ↩