[kafka] add system tests to consumer and producer data streams - #15334
[kafka] add system tests to consumer and producer data streams#15334stefans-elastic merged 11 commits into
Conversation
stefans-elastic
added
enhancement
| - version: "1.23.1" | ||
| changes: | ||
| - description: Add system tests for consumer and producer data streams. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/15334 |
There was a problem hiding this comment.
why enhancement with patch version update?
There was a problem hiding this comment.
because there is no changes to the functionality
…astic/integrations into kafka-consumer-producer-tests
🚀 Benchmarks reportTo see the full report comment with |
|
Can you regenerate the sample events for the producer dataset and update it as part of this PR? |
| @@ -0,0 +1,15 @@ | |||
| FROM apache/kafka:4.0.0 | |||
|
|
|||
There was a problem hiding this comment.
@stefans-elastic, The changes look good, but I was just wondering, what if we add the setup script to the parent _dev directory of this integration? That way, we can avoid repeating the script in each data stream, especially since there are quite a few data streams in Kafka that use JMX and share the same setup. Only the data stream–specific details might differ. WDYT?
There was a problem hiding this comment.
hmmm, let me try this
There was a problem hiding this comment.
it worked (at least locally), thanks for the suggestion!
Lets wait for the CI to complete to see if it works in CI tests
There was a problem hiding this comment.
I've actually reverted the change for raft data stream because when later on when we'll introduce variants for the tests we'll need a different set of variants for raft stream (because it would work only if kafka is run in KRaft mode)
done |
💚 Build Succeeded
History
|
|
|
Package kafka - 1.23.1 containing this change is available at https://epr.elastic.co/package/kafka/1.23.1/ |
…ic#15334) * [kafka] add system tests to consumer and producer data streams * update PR link * producer docker healthcheck * consumer docker healthcheck * update producer sample_event.json * moved docker tests setup from individual data streams to top level kafka _dev dir * revert raft data stream changes * fix file name
6 participants
Proposed commit message
See title
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots