Skip to content

[sentinel_one] Update README Instructions and Improve System Test Coverage - #15420

Merged
mohitjha-elastic merged 2 commits into
elastic:mainfrom
mohitjha-elastic:sentinel_one-1.39.0
Sep 23, 2025
Merged

[sentinel_one] Update README Instructions and Improve System Test Coverage#15420
mohitjha-elastic merged 2 commits into
elastic:mainfrom
mohitjha-elastic:sentinel_one-1.39.0

Conversation

@mohitjha-elastic

Copy link
Copy Markdown
Contributor

Proposed commit message

sentinel_one: update API token generation instructions in readme and improve system test coverage

Updated the README instructions for generating the API token, as the previous steps were based on an
older UI. Additionally, system test coverage for all data streams has been improved by including checks
ranging from Level 0, which verifies basic functionality, to Level 2, which ensures proper pagination.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/sentinel_one directory.
  • Run the following command to run tests.

elastic-package test -v

Related Issue

@mohitjha-elastic mohitjha-elastic self-assigned this Sep 22, 2025
@mohitjha-elastic
mohitjha-elastic requested a review from a team as a code owner September 22, 2025 12:18
@mohitjha-elastic mohitjha-elastic added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:sentinel_one SentinelOne Category: Integration quality Category: Quality used for SI planning Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Sep 22, 2025
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

cc @mohitjha-elastic

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

suggest commit message body:

Updated README instructions for generating the API token, as the
previous steps were based on an older UI.

Additionally, system test coverage for all data streams has been
improved by including checks ranging from Level 0, which verifies basic
functionality, to Level 2, which ensures proper pagination.
@mohitjha-elastic
mohitjha-elastic merged commit 2640643 into elastic:main Sep 23, 2025
9 checks passed
@mohitjha-elastic
mohitjha-elastic deleted the sentinel_one-1.39.0 branch September 23, 2025 05:59
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package sentinel_one - 1.39.0 containing this change is available at https://epr.elastic.co/package/sentinel_one/1.39.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Integration quality Category: Quality used for SI planning documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:sentinel_one SentinelOne Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants