trend_micro_vision_one: relocate common required options - #15427
Conversation
chemamartinez
added
breaking change
Integration:trend_micro_vision_one
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
In the upgrade path we see what is apparently the secret added twice (it's not). We could conceivably work around this by naming it with an input tag as well, but I think this would make the more common interaction with the option worse in order to improve this uncommon interaction. I think that probably fleet should do better when it sees that the names are the same and qualify them with the part of the configuration that they come from.
cc @nimarezainia ?
| multi: false | ||
| required: false | ||
| show_user: false | ||
| description: The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename) for details. No newline at end of file |
| multi: false | ||
| required: false | ||
| show_user: false | ||
| description: The request tracer logs requests and responses to the agent's local file-system for debugging configurations. Enabling this request tracing compromises security and should only be used for debugging. See [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-httpjson.html#_request_tracer_filename) for details. No newline at end of file |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
Have you confirmed that this fixes the upgrade issue by taking it through the problematic upgrade path manually?
@efd6 yes, I have tested the upgrade path The integration gets upgraded and conflicts in the policy have to be manually solved, after that, the integration is not affected by the bug anymore. |
|
Package trend_micro_vision_one - 2.4.0 containing this change is available at https://epr.elastic.co/package/trend_micro_vision_one/2.4.0/ |
``` To avoid bug described at elastic/kibana#235242, common required settings such as URL and API Token have been located under input level, as they were in previous versions. This forces users to solve conflicts in the integration configuration during upgrades from any version, avoiding the integration to gets broken once upgraded. Also, new telemetry data stream added in 2.2.0 has been disabled by default, so users that upgrade from 2.1.0 to this newest version don't face any breaking change and can decide later if they want to enable the new feature or not. Request tracing option has been moved to each data stream at the same time to allow for more granular control of request tracing. ```
3 participants
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
2.4.0 fresh install
All options are shown as expected:
Upgrade from < 2.2.0
As the
telemetrydata stream has been disabled by default, an upgrade from a version where this data stream didn't exist yet succeeds.Once upgraded, the new data stream is disabled tough, so users would have to enable it manually.
Upgrade from > 2.2.0
When clicking on
Upgrade to latest versionthe integration is upgraded but the policy upgrade fails due to conflicts. The breaking change forces users to update policies manually.Once the policy is manually upgraded and conflicts are solved, the integration works as expected and all config options appear in the UI for future editions. This is expected in a breaking change according to our docs.
After the upgrade, everything works fine.
Related issues