Skip to content

microsoft_defender_endpoint: ensure $skip parameter is correctly formatted - #15471

Merged
kcreddy merged 2 commits into
elastic:mainfrom
kcreddy:defender_endpoint-skip
Sep 26, 2025
Merged

microsoft_defender_endpoint: ensure $skip parameter is correctly formatted#15471
kcreddy merged 2 commits into
elastic:mainfrom
kcreddy:defender_endpoint-skip

Conversation

@kcreddy

@kcreddy kcreddy commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

microsoft_defender_endpoint: ensure $skip parameter is correctly formatted

The values used to populate this parameter can be greater than the
cutover to e-notation for doubles, so convert to int before converting
to string.

Fix is similar to #15392 as it the same API and CEL program.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@kcreddy kcreddy self-assigned this Sep 25, 2025
@kcreddy kcreddy added Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Sep 25, 2025
@kcreddy
kcreddy marked this pull request as ready for review September 25, 2025 19:15
@kcreddy
kcreddy requested a review from a team as a code owner September 25, 2025 19:15
@elasticmachine

elasticmachine commented Sep 25, 2025

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@elastic-sonarqube

elastic-sonarqube Bot commented Sep 25, 2025

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube
@elasticmachine

elasticmachine commented Sep 25, 2025

Copy link
Copy Markdown

💚 Build Succeeded

cc @kcreddy
@kcreddy
kcreddy requested a review from efd6 September 25, 2025 19:44
@efd6 efd6 mentioned this pull request Sep 25, 2025
Merged
5 tasks
@kcreddy
kcreddy merged commit 9e09eb3 into elastic:main Sep 26, 2025
9 checks passed
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Package microsoft_defender_endpoint - 3.1.1 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/3.1.1/
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
@kcreddy
microsoft_defender_endpoint: ensure $skip parameter is correctly form…
5644085 
…atted (elastic#15471)

microsoft_defender_endpoint: ensure $skip parameter is correctly formatted

The values used to populate this parameter can be greater than the
cutover to e-notation for doubles, so convert to int before converting
to string.

Fix is similar to elastic#15392 as it the same API and CEL program.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@kcreddy @elasticmachine @efd6