Skip to content

Replace localhost with node_name env var to access k8s proxy - #1565

Merged
MichaelKatsoulis merged 2 commits into
elastic:masterfrom
MichaelKatsoulis:update-proxy-default-host
Sep 1, 2021
Merged

Replace localhost with node_name env var to access k8s proxy#1565
MichaelKatsoulis merged 2 commits into
elastic:masterfrom
MichaelKatsoulis:update-proxy-default-host

Conversation

@MichaelKatsoulis

@MichaelKatsoulis MichaelKatsoulis commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Replaces the default host for proxy data stream in kubernetes package from localhost:10249 to ${env.NODE_NAME}:10249.
The proxy metrics can be fetched from the pod by using the k8s node name and proxy port as it is accessible from inside the pod.
This is a step towards getting rid of hostNetwork:true setting in agent deployment configuration.
elastic/beats#25739

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Screenshots

proxy

@ChrsMark ChrsMark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@elasticmachine

elasticmachine commented Sep 1, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-01T09:38:49.670+0000

  • Duration: 29 min 25 sec

  • Commit: ea86f2a

Test stats 🧪

Test Results
Failed 0
Passed 113
Skipped 0
Total 113

Trends 🧪

Image of Build Times

Image of Tests

@cfloressuazo

cfloressuazo commented Aug 10, 2022

Copy link
Copy Markdown

How should I setup by default the kubernetes integration with fleet? It seems like this PR breaks some of the ELK manifests for monitoring kubernetes

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…#1565)

* Replace localhost with node_name env var to access k8s proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants