Skip to content

[vSphere] Add vSphere package - #1579

Merged
jsoriano merged 9 commits into
elastic:masterfrom
legoguy1000:642-vsphere-package
Sep 15, 2021
Merged

[vSphere] Add vSphere package#1579
jsoriano merged 9 commits into
elastic:masterfrom
legoguy1000:642-vsphere-package

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds initial vSphere package (copied from Metricbeat module). Added syslog input for vCenter logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd integrations/packages/pfsense
elastic-package check && elastic-package stack down && elastic-package build && elastic-package stack up -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test  -v

Related issues

Screenshots

Dashboards copied from Metricbeat module
metricbeat_vsphere_vm_dashboard
metricbeat_vsphere_dashboard

@elasticmachine

elasticmachine commented Sep 6, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-14T14:37:58.444+0000

  • Duration: 14 min 46 sec

  • Commit: 0615c74

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

Trends 🧪

Image of Build Times

Image of Tests

@legoguy1000
legoguy1000 marked this pull request as ready for review September 6, 2021 19:52
@jamiehynds jamiehynds added the Team:Integrations Label for the Integrations team label Sep 8, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@legoguy1000 legoguy1000 mentioned this pull request Sep 8, 2021
4 tasks
Comment thread packages/vsphere/_dev/build/build.yml Outdated
Comment thread packages/vsphere/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated

@jsoriano jsoriano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the migration of this integration!

Comment thread packages/vsphere/_dev/build/docs/README.md Outdated
Comment thread packages/vsphere/changelog.yml Outdated
Comment thread packages/vsphere/data_stream/datastore/fields/ecs.yml Outdated
Comment thread packages/vsphere/data_stream/host/fields/ecs.yml Outdated
Comment thread packages/vsphere/data_stream/virtualmachine/fields/ecs.yml Outdated
Comment thread packages/vsphere/manifest.yml Outdated
@jsoriano

Copy link
Copy Markdown
Contributor

/test

@legoguy1000

Copy link
Copy Markdown
Contributor Author

@jsoriano Updates made

@jsoriano jsoriano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jsoriano

Copy link
Copy Markdown
Contributor

/test

@jsoriano

Copy link
Copy Markdown
Contributor

@legoguy1000 there seems to be some formatting issues, can you take a look?

@legoguy1000

Copy link
Copy Markdown
Contributor Author

@legoguy1000 there seems to be some formatting issues, can you take a look?

Done. The formatting will be the death of me

@jsoriano
jsoriano merged commit de2eafa into elastic:master Sep 15, 2021
@legoguy1000
legoguy1000 deleted the 642-vsphere-package branch September 15, 2021 10:43
@jamiehynds

jamiehynds commented Dec 9, 2021

Copy link
Copy Markdown

@jsoriano do you know if this package is stuck in staging? Don't see it listed in our integration docs or within the Kibana integrations page (7.16).

@jsoriano

jsoriano commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

do you know if this package is stuck in staging? Don't see it listed in our integration docs or within the Kibana integrations page (7.16).

Yes, I think this package has been never promoted to production. Pinging @elastic/integrations to see if this can be promoted.

@kaiyan-sheng

Copy link
Copy Markdown

I haven't tested this integration yet but seems like @marc-gr already made a bug fix on it. Marc, do you think this package is ready to be promoted? Also just a thought, maybe the owner should be the security-external-integrations team for now? 😄

@jamiehynds

jamiehynds commented Dec 9, 2021

Copy link
Copy Markdown

@kaiyan-sheng we reviewed as we work closely with @legoguy1000 on other integrations. Given that vSphere is more of an o11y use case, and the o11y team already own the metricbeat module, I think it makes more sense for o11y to continue to own the integration. /cc @akshay-saraswat

@andrewkroh andrewkroh added the Integration:vsphere VMware vSphere label Aug 13, 2024
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:vsphere VMware vSphere New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team

6 participants