Skip to content

Make Apache integration GA - #1607

Merged
sayden merged 4 commits into
elastic:masterfrom
sayden:make-ga/apache
Sep 13, 2021
Merged

Make Apache integration GA#1607
sayden merged 4 commits into
elastic:masterfrom
sayden:make-ga/apache

Conversation

@sayden

@sayden sayden commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

Release Apache integration as GA

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).
@sayden sayden added enhancement New feature or request Team:Integrations Label for the Integrations team labels Sep 9, 2021
@sayden sayden self-assigned this Sep 9, 2021
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

categories:
- web
release: experimental
release: ga

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be updated in the data stream manifests too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR "GA" for data streams means removing the "release" property at all (according to spec).

release: experimental
release: ga
conditions:
kibana.version: "^7.14.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it bound with a particular Kibana release or not?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't. Why the version should be different if everything is the same? Maybe I'm missing something 🤔

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had an offline chat with Jaime, I agree we can take the risk here and leave the constraint as is (please ignore this comment).

@elasticmachine

elasticmachine commented Sep 9, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-10T12:08:53.059+0000

  • Duration: 14 min 37 sec

  • Commit: f1a533c

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

Trends 🧪

Image of Build Times

Image of Tests

@mtojek
mtojek self-requested a review September 10, 2021 07:37

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unadressed comments.

@mtojek

mtojek commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

@sayden Please take a look at the CI report. If the package is "GA", you don't need the property "release".

@mtojek
mtojek self-requested a review September 10, 2021 12:23
@sayden

sayden commented Sep 13, 2021

Copy link
Copy Markdown
Contributor Author

Ok so I removed the release property from data_streams :)

@sayden
sayden merged commit 3f6fe1e into elastic:master Sep 13, 2021
@sayden
sayden deleted the make-ga/apache branch July 30, 2022 05:56
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

4 participants