Skip to content

ssi_some: remove duplicated field definitions in transforms - #16180

Merged
mrodm merged 3 commits into
elastic:mainfrom
mrodm:update_transforms_fields
Dec 2, 2025
Merged

ssi_some: remove duplicated field definitions in transforms#16180
mrodm merged 3 commits into
elastic:mainfrom
mrodm:update_transforms_fields

Conversation

@mrodm

@mrodm mrodm commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

Proposed commit message

Update field definitions in transforms to avoid duplicated fields found while working on elastic/elastic-package#2558

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@mrodm mrodm self-assigned this Dec 1, 2025
Comment on lines -17 to -18
- external: ecs
name: event.created

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field definition duplicated just above:

Error:

Error: checking package failed: linting package failed: found 1 validation error:

  1. field "event.created" is defined multiple times for transform "latest_offense", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239772963433816/elastic/integrations/packages/ibm_qradar/elasticsearch/transform/latest_offense/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239772963433816/elastic/integrations/packages/ibm_qradar/elasticsearch/transform/latest_offense/fields/ecs.yml
Comment on lines -75 to -78
- name: package.name
external: ecs
- name: package.version
external: ecs

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep just the field definitions in packages/rapid7_insightvm/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml:

- name: package
type: group
fields:
- name: fixed_version
type: keyword
- name: name
type: keyword
external: ecs
- name: version
type: keyword
external: ecs

Error:

Error: checking package failed: linting package failed: found 2 validation errors:

  1. field "package.name" is defined multiple times for transform "latest_cdr_vulnerabilities", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239778925107839/elastic/integrations/packages/rapid7_insightvm/elasticsearch/transform/latest_cdr_vulnerabilities/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239778925107839/elastic/integrations/packages/rapid7_insightvm/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml
  2. field "package.version" is defined multiple times for transform "latest_cdr_vulnerabilities", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239778925107839/elastic/integrations/packages/rapid7_insightvm/elasticsearch/transform/latest_cdr_vulnerabilities/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239778925107839/elastic/integrations/packages/rapid7_insightvm/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml
Comment on lines -52 to -57
- name: package.name
external: ecs
- name: package.path
external: ecs
- name: package.version
external: ecs

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the field definitions from: packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml

- name: package
type: group
fields:
- name: fixed_version
type: keyword
- name: name
type: keyword
external: ecs
- name: path
type: keyword
external: ecs
- name: version
type: keyword
external: ecs

Error:

Error: checking package failed: linting package failed: found 3 validation errors:

  1. field "package.version" is defined multiple times for transform "latest_cdr_vulnerabilities", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786045634364/elastic/integrations/packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786045634364/elastic/integrations/packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml
  2. field "package.path" is defined multiple times for transform "latest_cdr_vulnerabilities", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786045634364/elastic/integrations/packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786045634364/elastic/integrations/packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml
  3. field "package.name" is defined multiple times for transform "latest_cdr_vulnerabilities", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786045634364/elastic/integrations/packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786045634364/elastic/integrations/packages/tenable_io/elasticsearch/transform/latest_cdr_vulnerabilities/fields/package.yml
Comment on lines -7 to -9
- name: tags
type: keyword
description: User defined tags.

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the field definition from: packages/ti_crowdstrike/elasticsearch/transform/latest_ioc/fields/ecs.yml

Error:

Error: checking package failed: linting package failed: found 1 validation error:

  1. field "tags" is defined multiple times for transform "latest_ioc", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786988523423/elastic/integrations/packages/ti_crowdstrike/elasticsearch/transform/latest_ioc/fields/beats.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239786988523423/elastic/integrations/packages/ti_crowdstrike/elasticsearch/transform/latest_ioc/fields/ecs.yml
Comment on lines -47 to -56
# Below fields to be moved into base-fields.yml after kibana.version changed to >= 8.14
# Related to fix: https://github.com/elastic/kibana/pull/177608
- name: event.module
type: constant_keyword
description: Event module.
value: ti_custom
- name: event.dataset
type: constant_keyword
description: Event dataset.
value: ti_custom.indicator

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the field definitions from: packages/ti_custom/elasticsearch/transform/latest_ioc/fields/base-fields.yml

- name: event.module
type: constant_keyword
description: Event module
value: ti_custom
- name: event.dataset
type: constant_keyword
description: Event dataset
value: ti_custom.indicator

Error:

Error: checking package failed: linting package failed: found 2 validation errors:

  1. field "event.module" is defined multiple times for transform "latest_ioc", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239789143584049/elastic/integrations/packages/ti_custom/elasticsearch/transform/latest_ioc/fields/base-fields.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239789143584049/elastic/integrations/packages/ti_custom/elasticsearch/transform/latest_ioc/fields/ecs.yml
  2. field "event.dataset" is defined multiple times for transform "latest_ioc", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239789143584049/elastic/integrations/packages/ti_custom/elasticsearch/transform/latest_ioc/fields/base-fields.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239789143584049/elastic/integrations/packages/ti_custom/elasticsearch/transform/latest_ioc/fields/ecs.yml
Comment on lines -1 to -3
- name: "@timestamp"
type: date
description: Event timestamp.

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the field definition from: packages/ti_eclecticiq/elasticsearch/transform/latest_ioc/fields/base-fields.yml

- name: "@timestamp"
type: date
description: Event timestamp.

Error:

Error: checking package failed: linting package failed: found 1 validation error:

  1. field "@timestamp" is defined multiple times for transform "latest_ioc", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239787195394465/elastic/integrations/packages/ti_eclecticiq/elasticsearch/transform/latest_ioc/fields/base-fields.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764239787195394465/elastic/integrations/packages/ti_eclecticiq/elasticsearch/transform/latest_ioc/fields/fields.yml
Comment on lines -21 to -22
- external: ecs
name: organization.name

@mrodm mrodm Dec 1, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Field definition duplicated just above.

Error:

Error: checking package failed: linting package failed: found 1 validation error:

  1. field "organization.name" is defined multiple times for transform "ip", found in: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764240052938457124/elastic/integrations/packages/ti_greynoise/elasticsearch/transform/ip/fields/ecs.yml, /opt/buildkite-agent/builds/bk-agent-prod-gcp-1764240052938457124/elastic/integrations/packages/ti_greynoise/elasticsearch/transform/ip/fields/ecs.yml
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@mrodm
mrodm force-pushed the update_transforms_fields branch from 673cfd5 to afdd33f Compare December 1, 2025 15:48
external: ecs
- name: version
type: keyword
external: ecs

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: keyword
- name: tags
type: keyword
description: User defined tags.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the same description as in the other file.

@mrodm
mrodm marked this pull request as ready for review December 1, 2025 16:24
@mrodm
mrodm requested a review from a team as a code owner December 1, 2025 16:24
@mrodm
mrodm requested a review from a team December 1, 2025 16:54
@andrewkroh andrewkroh added Integration:tenable_io Tenable Vulnerability Management Integration:ti_custom Custom Threat Intelligence Integration:ti_eclecticiq EclecticIQ (Partner supported) Integration:ibm_qradar IBM QRadar Integration:rapid7_insightvm Rapid7 InsightVM Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Integration:ti_greynoise GreyNoise (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 1, 2025
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Suggest the following commit message:

ssi_some: remove duplicated field definitions in transforms

Field validation tooling improvements revealed duplicate field definitions
across multiple transform field files, causing package linting failures.
This removes the duplicate definitions while preserving correct field
mappings and increments transform versions to ensure proper updates.

Affected packages: ibm_qradar, rapid7_insightvm, tenable_io, 
ti_crowdstrike, ti_custom, ti_eclecticiq, ti_greynoise
@mrodm mrodm changed the title Remove duplicated fields in transforms Dec 2, 2025
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mrodm

@mrodm
mrodm merged commit 1ed3776 into elastic:main Dec 2, 2025
7 checks passed
@mrodm
mrodm deleted the update_transforms_fields branch December 2, 2025 12:00
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package ibm_qradar - 0.1.1 containing this change is available at https://epr.elastic.co/package/ibm_qradar/0.1.1/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package rapid7_insightvm - 2.5.1 containing this change is available at https://epr.elastic.co/package/rapid7_insightvm/2.5.1/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package tenable_io - 4.6.1 containing this change is available at https://epr.elastic.co/package/tenable_io/4.6.1/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package ti_crowdstrike - 2.6.1 containing this change is available at https://epr.elastic.co/package/ti_crowdstrike/2.6.1/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package ti_custom - 1.2.3 containing this change is available at https://epr.elastic.co/package/ti_custom/1.2.3/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package ti_eclecticiq - 1.4.2 containing this change is available at https://epr.elastic.co/package/ti_eclecticiq/1.4.2/

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package ti_greynoise - 0.7.2 containing this change is available at https://epr.elastic.co/package/ti_greynoise/0.7.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:ibm_qradar IBM QRadar Integration:rapid7_insightvm Rapid7 InsightVM Integration:tenable_io Tenable Vulnerability Management Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Integration:ti_custom Custom Threat Intelligence Integration:ti_eclecticiq EclecticIQ (Partner supported) Integration:ti_greynoise GreyNoise (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants