Skip to content

[Akamai SIEM] - Fixed pagination logic to use the number_of_events_returned >= event_limit conditional check instead of offset presence - #16225

Merged
ShourieG merged 4 commits into
elastic:mainfrom
ShourieG:bug_fix/akamai_16186
Dec 7, 2025
Merged

[Akamai SIEM] - Fixed pagination logic to use the number_of_events_returned >= event_limit conditional check instead of offset presence#16225
ShourieG merged 4 commits into
elastic:mainfrom
ShourieG:bug_fix/akamai_16186

Conversation

@ShourieG

@ShourieG ShourieG commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

akamai: fix pagination logic to use  number_of_events_returned >= event_limit 
conditional check instead of offset presence.

The integration was incorrectly using the offset field for pagination,
which caused issues with data retrieval. The Akamai SIEM API requires
checking the condition number_of_events_returned >= event_limit for 
proper pagination control.

Documentation: https://techdocs.akamai.com/siem-integration/reference/offsetcontext

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ShourieG ShourieG self-assigned this Dec 3, 2025
@ShourieG ShourieG added Integration:akamai Akamai bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 3, 2025
@ShourieG
ShourieG marked this pull request as ready for review December 3, 2025 11:51
@ShourieG
ShourieG requested a review from a team as a code owner December 3, 2025 11:51
@elasticmachine

elasticmachine commented Dec 3, 2025

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
efd6
efd6 reviewed Dec 4, 2025
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rémy suggests

akamai: fix pagination logic to use limit field instead of offset

The integration was incorrectly using the offset field for pagination,
which caused issues with data retrieval. The Akamai SIEM API requires
the limit field for proper pagination control.

Documentation: https://techdocs.akamai.com/siem-integration/reference/offsetcontext
Comment thread packages/akamai/data_stream/siem/agent/stream/cel.yml.hbs Outdated
efd6
efd6 approved these changes Dec 5, 2025
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for @andrewkroh
@ShourieG

ShourieG commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

@andrewkroh, made the suggested change, let me know if it's good to merge or not atm.
@elasticmachine

elasticmachine commented Dec 5, 2025

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @ShourieG
@ShourieG ShourieG changed the title [Akamai SIEM] - Fixed pagination logic to use the limit field instead of the offset field Dec 7, 2025
@ShourieG
ShourieG merged commit d9f6b9c into elastic:main Dec 7, 2025
7 checks passed
@ShourieG
ShourieG deleted the bug_fix/akamai_16186 branch December 7, 2025 15:51
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

Package akamai - 3.0.1 containing this change is available at https://epr.elastic.co/package/akamai/3.0.1/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:akamai Akamai Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@ShourieG @elasticmachine @andrewkroh @efd6