[cisco_ise] Extract av-pairs into attributes mapping - #16312
Conversation
80d5c67 to
3c140b2
Compare
🚀 Benchmarks reportTo see the full report comment with |
3c140b2 to
5002fa7
Compare
- Improved script for extracting nested subkeys from cisco-av-pair attribute/value pairs. - Add pipeline test for passed authentications.
5002fa7 to
706efba
Compare
💚 Build Succeeded
History
|
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
qcorporation
left a comment
There was a problem hiding this comment.
This looks good.
The only way that I can see this fail is if there's a third level nesting which I don't think is the case.
yields (cisco-av-pair, mdm-tlv omitted because it wasn't shown in the test diff and I don't feel like adding it: There is no imposed limit, it can handle any depth. I did try to test with escaped quotes in the key (since we talked about that), but it struggled with that (given how I'm detecting when the last key happens). I'm not really going to address that unless I see real evidence that there's a key with an escaped quote in it. It handles values with escaped quotes just fine. |
|
Package cisco_ise - 1.31.0 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.31.0/ |
Proposed commit message
Checklist
changelog.ymlfile.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally