Skip to content

[cisco_ise] Extract av-pairs into attributes mapping - #16312

Merged
taylor-swanson merged 1 commit into
elastic:mainfrom
taylor-swanson:enhance/cisco-ise-avpair
Dec 18, 2025
Merged

[cisco_ise] Extract av-pairs into attributes mapping#16312
taylor-swanson merged 1 commit into
elastic:mainfrom
taylor-swanson:enhance/cisco-ise-avpair

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Improved script for extracting nested sub-keys from cisco-av-pair attribute/value pairs.
  • Add pipeline test for passed authentications.
  • Added mappings for known sub-keys to satisfy tests. Dynamic mappings is enabled for cisco_av_pair, so any unknown keys will be created on-demand.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/cisco_ise
elastic-package test
@taylor-swanson taylor-swanson self-assigned this Dec 4, 2025
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Dec 4, 2025
@taylor-swanson
taylor-swanson force-pushed the enhance/cisco-ise-avpair branch 6 times, most recently from 80d5c67 to 3c140b2 Compare December 16, 2025 17:14
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson
taylor-swanson force-pushed the enhance/cisco-ise-avpair branch from 3c140b2 to 5002fa7 Compare December 16, 2025 18:55
- Improved script for extracting nested subkeys from cisco-av-pair
attribute/value pairs.
- Add pipeline test for passed authentications.
@taylor-swanson
taylor-swanson force-pushed the enhance/cisco-ise-avpair branch from 5002fa7 to 706efba Compare December 16, 2025 20:34
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson
taylor-swanson marked this pull request as ready for review December 16, 2025 21:33
@taylor-swanson
taylor-swanson requested a review from a team as a code owner December 16, 2025 21:33
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@qcorporation qcorporation left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
The only way that I can see this fail is if there's a third level nesting which I don't think is the case.

@taylor-swanson

Copy link
Copy Markdown
Contributor Author

This looks good. The only way that I can see this fail is if there's a third level nesting which I don't think is the case.

cisco-av-pair=mdm-tlv=this=can=go=quite=deep=no-real-limit=device-platform-version=10.0.26100

yields (cisco-av-pair, mdm-tlv omitted because it wasn't shown in the test diff and I don't feel like adding it:

+                            "device-uid-global": "2897F9C5734F41A03F0E89064463F6FAB5EEDBF1",
+                            "this": {
+                                "can": {
+                                    "go": {
+                                        "quite": {
+                                            "deep": {
+                                                "no-real-limit": {
+                                                    "device-platform-version": "10.0.26100"
+                                                }
+                                            }
+                                        }
+                                    }
+                                }
+                            }

There is no imposed limit, it can handle any depth. I did try to test with escaped quotes in the key (since we talked about that), but it struggled with that (given how I'm detecting when the last key happens). I'm not really going to address that unless I see real evidence that there's a key with an escaped quote in it. It handles values with escaped quotes just fine.

@taylor-swanson
taylor-swanson merged commit 1445559 into elastic:main Dec 18, 2025
8 checks passed
@taylor-swanson
taylor-swanson deleted the enhance/cisco-ise-avpair branch December 18, 2025 15:44
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.31.0 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.31.0/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

4 participants