[nginx_input_otel] Explicitly define variables for available settings - #16313
Merged
Conversation
jsoriano
force-pushed
the
nginx-otel-variables-tests
branch
from
December 4, 2025 19:00
417edca to
a4a200b
Compare
💚 Build Succeeded
cc @jsoriano |
andrewkroh
added
Integration:nginx_otel_input
Contributor
|
Package nginx_otel_input - 0.2.0 containing this change is available at https://epr.elastic.co/package/nginx_otel_input/0.2.0/ |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Define variables for available settings instead of allowing any configuration in YAML form. Having them as variables allows to document and validate them, being less error prone for users.
It will be also easier to reuse input packages in composable packages by clearly exposing its "interface".
See more detailed reasoning on https://github.com/elastic/integrations/pull/15651/files#r2590245547.
Also, add system and policy tests.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots