kafka_log: clarify default protocol version in description - #16516
Conversation
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
e9daafb to
62a53d2
Compare
62a53d2 to
7f5588c
Compare
💚 Build Succeeded
History
cc @mauri870 |
|
@agithomas / @stefans-elastic for review, given recent kafka upgrades. |
|
The change looks good to me. My suggestion would be to add a troubleshooting section in the README document to help those users migrating from the 8.x+ stack to the 9.x+ stack. In that process, the users would fail to notice this dependency. @stefans-elastic , as you have worked on the sarama library dependency issue pertaining to the metrics, kindly check from your end as well. Thanks. |
stefans-elastic
left a comment
There was a problem hiding this comment.
I agree: the change looks good. Also it matches the version we use in metricbeat.
Overall according to sarama code comment it is better to use lower version in sarama config than actual Kafka version it is running against because otherwise it may lead to random breakages.
|
Package kafka_log - 1.9.1 containing this change is available at https://epr.elastic.co/package/kafka_log/1.9.1/ |
Proposed commit message
The default Kafka protocol version depends on the filebeat version. For 8.x it defaults to 1.0.0, and for 9.0+ it defaults to 2.1.0. Update the description to clarify this.
Checklist
changelog.ymlfile.