Skip to content

kafka_log: clarify default protocol version in description - #16516

Merged
pierrehilbert merged 1 commit into
elastic:mainfrom
mauri870:kafka-default-version
Dec 18, 2025
Merged

kafka_log: clarify default protocol version in description#16516
pierrehilbert merged 1 commit into
elastic:mainfrom
mauri870:kafka-default-version

Conversation

@mauri870

Copy link
Copy Markdown
Member

Proposed commit message

The default Kafka protocol version depends on the filebeat version. For 8.x it defaults to 1.0.0, and for 9.0+ it defaults to 2.1.0. Update the description to clarify this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@mauri870 mauri870 self-assigned this Dec 11, 2025
@mauri870
mauri870 requested a review from a team as a code owner December 11, 2025 19:07
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Integration:kafka_log Kafka Log Consumer bugfix Pull request that fixes a bug issue labels Dec 11, 2025
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
mauri870 force-pushed the kafka-default-version branch from e9daafb to 62a53d2 Compare December 11, 2025 19:08
@mauri870
mauri870 force-pushed the kafka-default-version branch from 62a53d2 to 7f5588c Compare December 11, 2025 19:32
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @mauri870

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Dec 11, 2025
@lalit-satapathy

Copy link
Copy Markdown
Contributor

@agithomas / @stefans-elastic for review, given recent kafka upgrades.

@agithomas

Copy link
Copy Markdown
Contributor

The change looks good to me. My suggestion would be to add a troubleshooting section in the README document to help those users migrating from the 8.x+ stack to the 9.x+ stack. In that process, the users would fail to notice this dependency.

@stefans-elastic , as you have worked on the sarama library dependency issue pertaining to the metrics, kindly check from your end as well. Thanks.

@stefans-elastic stefans-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree: the change looks good. Also it matches the version we use in metricbeat.
Overall according to sarama code comment it is better to use lower version in sarama config than actual Kafka version it is running against because otherwise it may lead to random breakages.

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval based on the above-mentioned validations.

@pierrehilbert
pierrehilbert merged commit 4a02e7a into elastic:main Dec 18, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package kafka_log - 1.9.1 containing this change is available at https://epr.elastic.co/package/kafka_log/1.9.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:kafka_log Kafka Log Consumer Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

8 participants