-
Notifications
You must be signed in to change notification settings - Fork 634
[Azure Logs / Custom Azure Logs] Switch default processor to v2 #16618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1b6d77c
ab9c392
c39ea5f
a8661cb
ca9e60d
aa0a8b0
7edce00
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,10 +19,30 @@ storage_account: {{storage_account}} | |
| {{/if}} | ||
| {{#if storage_account_key}} | ||
| storage_account_key: {{storage_account_key}} | ||
| storage_account_connection_string: DefaultEndpointsProtocol=https;AccountName={{storage_account}};AccountKey={{storage_account_key}};EndpointSuffix={{endpoint_suffix}} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: i'm guessing same with
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We'll have the opportunity to clean things up a little when we'll drop v1 in a couple of iterations. |
||
| {{/if}} | ||
| {{#if resource_manager_endpoint}} | ||
| resource_manager_endpoint: {{resource_manager_endpoint}} | ||
| {{/if}} | ||
| {{#if processor_version}} | ||
| processor_version: {{processor_version}} | ||
| {{/if}} | ||
| {{#if migrate_checkpoint}} | ||
| migrate_checkpoint: {{migrate_checkpoint}} | ||
| {{/if}} | ||
| {{#if processor_update_interval}} | ||
| processor_update_interval: {{processor_update_interval}} | ||
| {{/if}} | ||
| {{#if processor_start_position}} | ||
| processor_start_position: {{processor_start_position}} | ||
| {{/if}} | ||
| {{#if partition_receive_timeout}} | ||
| partition_receive_timeout: {{partition_receive_timeout}} | ||
| {{/if}} | ||
| {{#if partition_receive_count}} | ||
| partition_receive_count: {{partition_receive_count}} | ||
| {{/if}} | ||
|
|
||
| tags: | ||
| {{#if preserve_original_event}} | ||
| - preserve_original_event | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,109 @@ streams: | |
| type: bool | ||
| multi: false | ||
| default: false | ||
| # | ||
| # Processor v2 only settings | ||
| # | ||
| - name: processor_version | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are we ok that integration upgrades are going to automatically enable v2 without the user explicitly choosing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to push users to the processor v2 while v1 is still available as fallback option. So if v2 falls short for any reason, users can still fallback to v1 while we address the problem. We need to drop v11 as soon as possible, since the v1's libraries are so old that sticking with them is becoming a risk. Footnotes
|
||
| type: select | ||
| title: Processor version | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: v2 | ||
| options: | ||
| - text: v1 (legacy) | ||
| value: v1 | ||
| - text: v2 | ||
| value: v2 | ||
| description: > | ||
| The processor version that the integration should use. Possible values are v1 (legacy) and v2 (recommended). | ||
| The v2 event hub processor is recommended for typical use cases. Defaults to v2. | ||
| - name: processor_update_interval | ||
| type: text | ||
| title: Processor update interval | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: 10s | ||
| description: >- | ||
| (Processor v2 only) How often the processor should attempt to claim partitions. | ||
|
|
||
| Default is `10` seconds. | ||
| - name: processor_start_position | ||
| type: select | ||
| title: Processor start position | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: earliest | ||
| options: | ||
| - text: earliest | ||
| value: earliest | ||
| - text: latest | ||
| value: latest | ||
| description: >- | ||
| (Processor v2 only) Controls from what position in the event hub the processor should start processing messages for all partitions. | ||
|
|
||
| Possible values are `earliest` and `latest`. | ||
|
|
||
| `earliest` starts processing messages from the last checkpoint, or the beginning of the event hub if no checkpoint is available. | ||
|
|
||
| `latest` starts processing messages from the the latest event in the event hub and continues to process new events as they arrive. | ||
|
|
||
| Default is `earliest`. | ||
| - name: partition_receive_timeout | ||
| type: text | ||
| title: Partition receive timeout | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: 5s | ||
| description: >- | ||
| (Processor v2 only) Maximum time to wait before processing the messages received from the event hub. | ||
|
|
||
| The partition consumer waits up to a "receive count" or a "receive timeout", whichever comes first. | ||
|
|
||
| Default is `5` seconds. | ||
| - name: partition_receive_count | ||
| type: text | ||
| title: Partition receive count | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: 100 | ||
| description: >- | ||
| (Processor v2 only) Maximum number of messages from the event hub to wait for before processing them. | ||
|
|
||
| The partition consumer waits up to a "receive count" or a "receive timeout", whichever comes first. | ||
|
|
||
| Default is `100` messages. | ||
| - name: migrate_checkpoint | ||
| type: bool | ||
| title: Migrate checkpoint information | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: true | ||
| description: >- | ||
| (Processor v2 only) Controls processor behavior upon the initial transition from v1 to v2. If you are | ||
| starting directly with v2, you can disregard this setting. | ||
|
|
||
| Defaults to `true`, which means the processor will automatically migrate checkpoint information from the | ||
| v1 format to v2. | ||
|
|
||
| If set to `false`, the processor will bypass existing v1 checkpoints and replay all events in the | ||
| Event Hub from the start of the retention window. For example, if set to `false` on an Event Hub with | ||
| a 1-hour retention period, the processor will replay the last hour's worth of data. | ||
| - name: endpoint_suffix | ||
| type: text | ||
| default: core.windows.net | ||
| required: true | ||
| title: Storage account endpoint suffix | ||
| show_user: false | ||
| description: >- | ||
| (Processor v2 only) Override the default storage account endpoint suffix. | ||
|
|
||
| # Ensures agents have permissions to write data to `logs-*-*` | ||
| elasticsearch: | ||
| dynamic_dataset: true | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "the integration preview" mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We introduced the new
eventsdata stream as the entry point and router for the Azure Logs integration package.I plan to make the
eventsdata stream (aka Azure Logs v2) as the only data stream running an input.Unfortunately, years ago we updated the Azure Logs packages to allow multiple inputs to read from the same event hub, but this is a fatal flaw. We need to get rid of this.
The other data streams (activitylogs, firewall_logs, etc) are going to stay without an input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We marked this
eventsdata stream named Azure Logs v2 as "preview" because we were not 100% sure this approach would work. But it seems working pretty well.