[Carbon Black Cloud] - Make rows_per_page in alerts_v7 data stream configurable and cap it at a maximum value of 10000 - #16960
Merged
Conversation
ShourieG
added
Integration:carbon_black_cloud
ShourieG
marked this pull request as ready for review
January 14, 2026 13:51
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| }), | ||
| "rows": state.rows_per_page, | ||
| // Cap rows_per_page to maximum value of 10000. | ||
| "rows": (state.rows_per_page > 10000) ? 10000 : state.rows_per_page, |
Contributor
There was a problem hiding this comment.
It seems that the indentation of this variable is making system tests fail with:
ERROR: could not add data stream config to policy: could not add package to policy; API status code = 400; response body = {"statusCode":400,"error":"Bad Request","message":"tab characters must not be used in indentation (68:1)\n\n 65 | →→→→→→)\n 66 | →→→→→:\n 67 | →→→→→→state.?cursor.last_back ...\n 68 | →→→→},\n------^\n 69 | →→→→\"want_more\": body.num_found ...\n 70 | →→→}"}
Contributor
Author
There was a problem hiding this comment.
did a celfmt format, should fix the tab issue as well as have better code formatting
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
asset_vulnerability_summary |
15384.62 | 11363.64 | -4020.98 (-26.14%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
cc @ShourieG |
Contributor
|
Package carbon_black_cloud - 4.2.0 containing this change is available at https://epr.elastic.co/package/carbon_black_cloud/4.2.0/ |
jakubgalecki0
pushed a commit
to jakubgalecki0/integrations
that referenced
this pull request
Feb 19, 2026
…nfigurable and cap it at a maximum value of 10000 (elastic#16960) carbon_black_cloud: Make rows_per_page in alerts_v7 data stream configurable and cap it at a maximum value of 10000. Added configurable rows_per_page setting to Carbon Black Cloud alert_v7 data stream with default of 100. Values exceeding the API maximum of 10000 are automatically capped. Having this option configurable helps us avoid scenarios where we encounter errors related to CEL executions due to having a large volume of alerts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Proposed commit message
NOTE:
According to official docs, the max value of
rows_per_pageis 10000.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots