[cisco_ise] fix data purge timezone detection - #17005
Merged
Merged
Conversation
ash-darin
commented
Jan 20, 2026
| field: message | ||
| patterns: | ||
| - '%{TIMEONLYSTAMP_ISO8601:_tmp.timestamp} %{ISO8601_TIMEZONE:_tmp.timezone} %{DATA:event.sequence:long} %{DATA:log.syslog.severity.name} %{DATA:cisco_ise.log.message.description}, %{GREEDYDATA:cisco_ise.log.log_details_raw},' | ||
| - '%{TIMEONLYSTAMP_ISO8601:_tmp.timestamp} %{ISO8601_TIMEZONE:event.timezone} %{DATA:event.sequence:long} %{DATA:log.syslog.severity.name} %{DATA:cisco_ise.log.message.description}, %{GREEDYDATA:cisco_ise.log.log_details_raw},' |
Contributor
Author
There was a problem hiding this comment.
This is event.timezone in all other pipelines.
ash-darin
marked this pull request as ready for review
January 20, 2026 13:30
andrewkroh
added
the
Team:Integration-Experience
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
Contributor
|
Change looks fine to me. I went ahead and fixed up the changelog and manifest file, and also regenerated the test expected files. As a side note, some of the timestamps in the logs don't have a year, so whenever we move to a new year, a lot of those timestamps in the expected files will change ( |
Contributor
|
/test |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
taylor-swanson
approved these changes
Jan 26, 2026
Contributor
|
Package cisco_ise - 1.31.2 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.31.2/ |
jakubgalecki0
pushed a commit
to jakubgalecki0/integrations
that referenced
this pull request
Feb 19, 2026
- Fix handling of time zone in data purge pipeline - Add test case with diverging time zone - Regenerate test expected files, updated year to 2026 for original timestamps lacking a year --------- Co-authored-by: Taylor Swanson <taylor.swanson@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
All pipelines except pipeline_monitoring_data_purge_audit subpipline extract the timezone of the event to event.timezone. (Compare:
integrations/packages/cisco_ise/data_stream/log/elasticsearch/ingest_pipeline/pipeline_identity_stores_diagnostics.yml
Line 12 in fa0203e
If this is not done, the timestamp will not be parsed correctly by the following logic. This PR brings the pipeline in line with all other pipelines.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
I added a testcase with a diverging timezone. Other than that you should check your installation for
cisco_ise.log.category.name: CISE_MONITORING_DATA_PURGE_AUDIT