Skip to content

[Cybereason] Add system test coverage - #17017

Merged
moxarth-rathod merged 2 commits into
elastic:mainfrom
moxarth-rathod:cybereason-system-test-coverage
Jan 27, 2026
Merged

[Cybereason] Add system test coverage#17017
moxarth-rathod merged 2 commits into
elastic:mainfrom
moxarth-rathod:cybereason-system-test-coverage

Conversation

@moxarth-rathod

@moxarth-rathod moxarth-rathod commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

cybereason: add system tests and increase base64 icon field limits to 4096

Add system tests for all data streams.

Also address field indexing issues identified by the new tests where
base64-encoded icons were being ignored due to insufficient field
length limits. The limits are increased from the default to 4096
characters for icon-related fields in suspicions_process and
malop_process data streams.

Test logs were generated from existing pipeline test logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Jan 21, 2026
@moxarth-rathod
moxarth-rathod requested a review from a team as a code owner January 21, 2026 10:50
@moxarth-rathod moxarth-rathod added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:cybereason Cybereason Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jan 21, 2026
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package cybereason 👍(2) 💚(2) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
malop_process 805.15 451.06 -354.09 (-43.98%) 💔
malware 10526.32 8000 -2526.32 (-24%) 💔

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jan 21, 2026

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message. At the moment it does not make any comment on the test addition. The work here is more complex than the proposed commit message would suggest. There are new test samples in the docker config, so the origin of these should be described in the commit message.

Comment thread packages/cybereason/changelog.yml Outdated
Comment thread packages/cybereason/changelog.yml Outdated
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @moxarth-rathod

@moxarth-rathod
moxarth-rathod requested a review from efd6 January 22, 2026 07:18

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest:

cybereason: add system tests and increase base64 icon field limits to 4096

Add system tests for all data streams.

Also address field indexing issues identified by the new tests where
base64-encoded icons were being ignored due to insufficient field
length limits. The limits are increased from the default to 4096
characters for icon-related fields in suspicions_process and
malop_process data streams.

Test logs were generated from existing pipeline test logs.
@moxarth-rathod
moxarth-rathod requested a review from efd6 January 23, 2026 05:32

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@moxarth-rathod
moxarth-rathod merged commit f1a54b0 into elastic:main Jan 27, 2026
8 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cybereason - 1.4.1 containing this change is available at https://epr.elastic.co/package/cybereason/1.4.1/

jakubgalecki0 pushed a commit to jakubgalecki0/integrations that referenced this pull request Feb 19, 2026
cybereason: add system tests and increase base64 icon field limits to 4096

Add system tests for all data streams.

Also address field indexing issues identified by the new tests where
base64-encoded icons were being ignored due to insufficient field
length limits. The limits are increased from the default to 4096
characters for icon-related fields in suspicions_process and
malop_process data streams.

Test logs were generated from existing pipeline test logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:cybereason Cybereason Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants