[backport 2.0] GCP infra manager link - #17255
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
This PR backports changes from #17036 to the 2.0.x branch (Kibana 8.19.x), updating the GCP CloudShell URL to use the main branch and a new infrastructure-manager workspace path instead of the previous deployment-manager path.
Changes:
- Updated GCP CloudShell URL to reference "main" branch instead of "8.19"
- Changed workspace path from "deploy/deployment-manager" to "deploy/infrastructure-manager/gcp-elastic-agent"
- Bumped package version from 2.0.1 to 2.0.2
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/cloud_security_posture/manifest.yml | Updated version to 2.0.2 and modified GCP CloudShell URL with new branch and workspace path |
| packages/cloud_security_posture/changelog.yml | Added changelog entry for version 2.0.2 documenting the GCP infrastructure manager link update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| show_user: false | ||
| description: A URL to CloudShell for creating a new deployment | ||
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=8.19&cloudshell_workspace=deploy%2Fdeployment-manager&show=terminal | ||
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=main&cloudshell_workspace=deploy%2Finfrastructure-manager%2Fgcp-elastic-agent&show=terminal |
There was a problem hiding this comment.
The GCP CloudShell URL is using "main" branch while this is a backport to the 2.0.x branch which is for Kibana 8.19.x. This creates an inconsistency within the same file where the Azure ARM template URL (line 171) still references the "8.19" branch. Consider whether the GCP URL should also use "8.19" branch instead of "main" to maintain consistency and ensure compatibility with Kibana 8.19.x, or if the Azure URL should also be updated to use a different branch.
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=main&cloudshell_workspace=deploy%2Finfrastructure-manager%2Fgcp-elastic-agent&show=terminal | |
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=8.19&cloudshell_workspace=deploy%2Finfrastructure-manager%2Fgcp-elastic-agent&show=terminal |
andrewkroh
added
the
Integration:cloud_security_posture
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Fix CI failure caused by Go 1.24.2 no longer being available for download. Co-authored-by: Cursor <cursoragent@cursor.com>
GVM v0.5.2 uses the old storage.googleapis.com URL format which now returns 403 errors. GVM v0.6.0 uses go.dev/dl which properly redirects to the working download URLs. Also update .go-version to 1.25.7 (current stable). Co-authored-by: Cursor <cursoragent@cursor.com>
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
Backport of #17036 to cloud_security_posture 2.0.x (Kibana 8.19.x)
Summary
Original PR
#17036
Made with Cursor