[backport 1.1] GCP infra manager link - #17267
Conversation
There was a problem hiding this comment.
Pull request overview
This PR backports changes from #17036 to the cloud_asset_inventory 1.1.x branch (compatible with Kibana 9.2.x). The changes update the GCP CloudShell URL to reference the main branch instead of the 9.2 branch and modify the workspace path from deploy/deployment-manager to deploy/infrastructure-manager/gcp-elastic-agent.
Changes:
- Version bumped from 1.1.6 to 1.1.7
- GCP CloudShell URL updated to use main branch and new infrastructure-manager workspace path
- Changelog entry added documenting the enhancement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/cloud_asset_inventory/manifest.yml | Updated version to 1.1.7 and modified GCP CloudShell URL to reference main branch with new workspace path |
| packages/cloud_asset_inventory/changelog.yml | Added version 1.1.7 changelog entry documenting the GCP infrastructure manager link update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| show_user: false | ||
| description: A URL to CloudShell for creating a new deployment | ||
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=9.2&cloudshell_workspace=deploy%2Fdeployment-manager&show=terminal | ||
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=main&cloudshell_workspace=deploy%2Finfrastructure-manager%2Fgcp-elastic-agent&show=terminal |
There was a problem hiding this comment.
The CloudShell URL now references the 'main' branch while other deployment URLs in the same manifest (Azure ARM templates at lines 93 and 102) still reference the '9.2' branch. This creates an inconsistency within the same integration version. For a backport to the 1.1.x branch (targeting Kibana 9.2.x), consider whether all deployment URLs should reference the same branch version for consistency, or if there's a specific reason why GCP CloudShell should point to 'main' while Azure templates point to '9.2'.
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=main&cloudshell_workspace=deploy%2Finfrastructure-manager%2Fgcp-elastic-agent&show=terminal | |
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=9.2&cloudshell_workspace=deploy%2Finfrastructure-manager%2Fgcp-elastic-agent&show=terminal |
| # 0.1.x - 8.15.x | ||
| - version: "1.1.7" | ||
| changes: | ||
| - description: GCP infra manager link |
There was a problem hiding this comment.
The changelog description "GCP infra manager link" could be more descriptive to match the style of similar entries. Consider a more detailed description such as "Updated GCP CloudShell URL to use main branch and infrastructure-manager workspace path" to better describe what changed and provide more context for users reviewing the changelog.
| - description: GCP infra manager link | |
| - description: Updated GCP CloudShell URL to use main branch and infrastructure-manager workspace path |
Co-authored-by: Cursor <cursoragent@cursor.com>
💚 Build Succeeded
History
|
|
Found 1.3.0 version is also pointing to kibana 9.2.x |
Backport of #17036 to cloud_asset_inventory 1.1.x (Kibana 9.2.x)
Summary
Original PR
#17036
Made with Cursor