cloud_security_posture: Add gcp_credentials_cloud_connector_id to GCP stream and mark as secret - #17378
Conversation
…et (3.3.0-preview05)
There was a problem hiding this comment.
Pull request overview
This PR updates the cloud_security_posture integration to support passing a GCP Cloud Connector ID through the findings GCP stream configuration, ensures the value is treated as a secret in the findings data stream manifest, and bumps the package version accordingly.
Changes:
- Bump
cloud_security_posturepackage version to3.3.0-preview05. - Mark
gcp_credentials_cloud_connector_idassecret: truein the findings data stream manifest. - Render
cloud_connector_idin the GCP findings stream template whengcp_credentials_cloud_connector_idis provided, and add a corresponding changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/cloud_security_posture/manifest.yml | Bumps the integration version to 3.3.0-preview05. |
| packages/cloud_security_posture/data_stream/findings/manifest.yml | Marks gcp_credentials_cloud_connector_id as a secret var. |
| packages/cloud_security_posture/data_stream/findings/agent/stream/gcp.yml.hbs | Adds cloud_connector_id rendering into the GCP credentials block. |
| packages/cloud_security_posture/changelog.yml | Adds a new entry for 3.3.0-preview05. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| audience: {{gcp.credentials.audience}} | ||
| {{/if}} | ||
| {{#if gcp_credentials_cloud_connector_id}} | ||
| cloud_connector_id: {{gcp_credentials_cloud_connector_id}} |
There was a problem hiding this comment.
cloud_connector_id is rendered without quoting or an explicit string tag. For consistency with project_id/organization_id in this same template (which use !!str) and to avoid YAML type coercion (e.g., numeric-looking IDs), render gcp_credentials_cloud_connector_id as a string (quote it or use !!str).
| cloud_connector_id: {{gcp_credentials_cloud_connector_id}} | |
| cloud_connector_id: !!str {{gcp_credentials_cloud_connector_id}} |
| - version: "3.3.0-preview05" | ||
| changes: | ||
| - description: Add gcp_credentials_cloud_connector_id to GCP stream template and mark as secret | ||
| type: enhancement |
There was a problem hiding this comment.
Changelog entries in this file consistently include a link: to the originating PR (e.g., the immediately following entry for 3.3.0-preview04 includes link: at lines 25-29). This new 3.3.0-preview05 entry is missing it; please add the PR link to keep changelog format consistent and maintain traceability.
andrewkroh
added
the
Integration:cloud_security_posture
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
Package cloud_security_posture - 3.3.0-preview05 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/3.3.0-preview05/ |
… stream and mark as secret (elastic#17378) * Add gcp_credentials_cloud_connector_id to GCP stream and mark as secret (3.3.0-preview05) * Add PR link to changelog
|
Package cloud_security_posture - 3.3.0-preview06 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/3.3.0-preview06/ |
|
Package cloud_security_posture - 3.3.0 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/3.3.0/ |
Summary
gcp_credentials_cloud_connector_idtodata_stream/findings/agent/stream/gcp.yml.hbs(cloud_connector_id in credentials).gcp_credentials_cloud_connector_idas secret in findings manifest.