[redis_otel] Add redis otel content pack - #17681
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
andrewkroh
added
New Integration
|
@claude review the PR.
|
|
Claude finished @ishleenk17's task in 3m 26s —— View job Review Complete: [redis_otel] Add redis otel content packI've reviewed this PR against the specified criteria and submitted an APPROVE review. Review Checklist:
Review Summary:
Dashboard Screenshots Review:
Additional Observations:
--- | Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've reviewed this PR against the specified criteria. The package is well-structured and follows the patterns of other OpenTelemetry integration packages.
Review Summary:
| Criteria | Status | Notes |
|---|---|---|
| Dashboard YAML files | N/A | Dashboards in this repo are JSON (standard practice) |
| Category has opentelemetry | ✅ Pass | categories: [datastore, observability, opentelemetry] |
| Kibana version ≥ 9.2.1 | ✅ Pass | Set to ^9.3.0 |
| Screenshots in manifest | ✅ Pass | Both dashboard screenshots included |
| discovery.fields | ✅ OK | Uses discovery.datasets which is consistent with similar packages |
| Service + OTel logo | ✅ Pass | Logo combines Redis icon with OpenTelemetry branding |
| README collector config | ✅ Pass | Includes configuration example and version info |
Additional Observations:
- Package passes
elastic-package lint - Changelog properly references this PR
- Dashboard screenshots look well-organized with appropriate sections for Memory, Connections, Replication, and Persistence
- Alert rules and SLO templates are well-defined with appropriate thresholds
- README includes Redis receiver v0.145.0 and Redis 6.x/7.x compatibility
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
|
@Linu-Elias : Why is the keyspace hit ration percentage above 1100%. Please check |
| | **[Redis OTel] Primary has no connected replicas** | Primary instance has zero connected replicas | High | | ||
|
|
||
| ## SLO templates | ||
|
|
There was a problem hiding this comment.
Note for SLO dependency on stack
|
To make this compatible with kb-dashboard 0.4.0 (released 3/17), run the automated upgrade and recompile: # 1. Upgrade YAML files in-place (handles all schema renames automatically)
uvx kb-dashboard-cli upgrade --write --input-dir packages/<PACKAGE>/_dev/shared/kibana
# 2. Recompile
uvx kb-dashboard-cli compile \
--input-dir packages/<PACKAGE>/_dev/shared/kibana \
--output-dir packages/<PACKAGE>/kibana/dashboard \
--format jsonThe
Review the diff after upgrading to confirm the changes look correct, then recompile and commit. |
|
I ran Results
Upgrade and post-upgrade compile succeeded with 0.4.0. Suggested commands: uvx --from kb-dashboard-cli==0.4.0 kb-dashboard upgrade --input-dir packages/redis_otel/_dev/shared/kibana --write
uvx --from kb-dashboard-cli==0.4.0 kb-dashboard compile --input-dir packages/redis_otel/_dev/shared/kibana --output-dir packages/redis_otel/kibana/dashboard --format elastic-integrations |
|
/test |
This reverts commit 261ff7c.
💚 Build Succeeded
History
|
|
Package redis_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/redis_otel/0.1.0/ |
* add package * changelog * manifest * fix lint * add yaml * kb-dashboard compatibility * kb-dashboard compatibility * Revert "kb-dashboard compatibility" This reverts commit 261ff7c.
7 participants
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots