[PPS]: Fix parsing for plain usernames and space-padded dates for syslog messages - #17742
Merged
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Mar 10, 2026
Comment on lines
+67
to
+68
| - "MMM dd HH:mm:ss" | ||
| - "MMM d HH:mm:ss" |
Contributor
There was a problem hiding this comment.
Suggested change
| - "MMM dd HH:mm:ss" | |
| - "MMM d HH:mm:ss" | |
| - "MMM [dd][ d] HH:mm:ss" |
Comment on lines
+82
to
+83
| - "MMM dd HH:mm:ss" | ||
| - "MMM d HH:mm:ss" |
Contributor
There was a problem hiding this comment.
Suggested change
| - "MMM dd HH:mm:ss" | |
| - "MMM d HH:mm:ss" | |
| - "MMM [dd][ d] HH:mm:ss" |
Contributor
Author
|
@efd6, resolved all comments |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @ShourieG |
efd6
approved these changes
Mar 11, 2026
Contributor
|
Package pps - 1.2.1 containing this change is available at https://epr.elastic.co/package/pps/1.2.1/ |
|
Hi @ShourieG , thank you for the fix. However, I have noticed that the new pattern in the date processor struggles when numbers for the day and for the hour are the same. E.g. "Mar 10 10:00:00" leads to an error, while "Mar 11 10:00:00" is working just fine. Would it be possible for you to address this issue? Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots