Skip to content

[PPS]: Fix parsing for plain usernames and space-padded dates for syslog messages - #17742

Merged
ShourieG merged 3 commits into
elastic:mainfrom
ShourieG:bugfix/6965
Mar 11, 2026
Merged

[PPS]: Fix parsing for plain usernames and space-padded dates for syslog messages #17742
ShourieG merged 3 commits into
elastic:mainfrom
ShourieG:bugfix/6965

Conversation

@ShourieG

@ShourieG ShourieG commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Bug

Proposed commit message

pps: fix parsing for plain usernames and space-padded dates

Adds a grok pattern variant to handle syslog messages where the username
has no domain suffix (e.g. `jsmith - Admins - Success` vs `user@domain - Success`).

This also fixes the `Backup Restore Service` entries which were previously
matched by the fallback pattern and incorrectly mapped the hostname to
`host.domain` instead of `host.hostname`.

Also adds `MMM  d HH:mm:ss` as an additional date format to handle BSD syslog's
space-padded single-digit days (e.g. `Feb  5`), which caused the date processor
to throw a parse error at index 4.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG self-assigned this Mar 10, 2026
@ShourieG
ShourieG requested a review from a team as a code owner March 10, 2026 15:59
@ShourieG ShourieG added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:pps Pleasant Password Server (Community supported) labels Mar 10, 2026
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG changed the title Fix grok pattern for handling syslog messages from Pleasant Password … Mar 10, 2026
Comment on lines +67 to +68
- "MMM dd HH:mm:ss"
- "MMM d HH:mm:ss"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "MMM dd HH:mm:ss"
- "MMM d HH:mm:ss"
- "MMM [dd][ d] HH:mm:ss"
Comment on lines +82 to +83
- "MMM dd HH:mm:ss"
- "MMM d HH:mm:ss"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "MMM dd HH:mm:ss"
- "MMM d HH:mm:ss"
- "MMM [dd][ d] HH:mm:ss"
@ShourieG

Copy link
Copy Markdown
Contributor Author

@efd6, resolved all comments

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @ShourieG

@ShourieG
ShourieG requested a review from efd6 March 11, 2026 05:59
@ShourieG
ShourieG merged commit bf7e61b into elastic:main Mar 11, 2026
9 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package pps - 1.2.1 containing this change is available at https://epr.elastic.co/package/pps/1.2.1/

@ghost

ghost commented Mar 23, 2026

Copy link
Copy Markdown

Hi @ShourieG , thank you for the fix. However, I have noticed that the new pattern in the date processor struggles when numbers for the day and for the hour are the same. E.g. "Mar 10 10:00:00" leads to an error, while "Mar 11 10:00:00" is working just fine. Would it be possible for you to address this issue? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:pps Pleasant Password Server (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants