Skip to content

Move defender_atp to new GA package microsoft_defender_endpoint - #1777

Merged
adriansr merged 11 commits into
elastic:masterfrom
adriansr:msdep
Sep 30, 2021
Merged

Move defender_atp to new GA package microsoft_defender_endpoint #1777
adriansr merged 11 commits into
elastic:masterfrom
adriansr:msdep

Conversation

@adriansr

@adriansr adriansr commented Sep 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

Relates #1562

Screenshots

Screenshot 2021-09-29 at 21-11-48 Microsoft Defender for Endpoint - Integrations - Elastic

Screenshot 2021-09-29 at 21-09-16 Add integration - Microsoft Defender for Endpoint - Integrations - Elastic
@adriansr adriansr added Team:Security-External Integrations New Integration Issue or pull request for creating a new integration package. labels Sep 29, 2021
@elasticmachine

elasticmachine commented Sep 29, 2021 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-30T16:37:20.607+0000

  • Duration: 16 min 35 sec

  • Commit: 10c78bf

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
P1llus
P1llus approved these changes Sep 30, 2021
View reviewed changes

@P1llus P1llus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, feel free to ignore any that you think is not necessary :)
Comment thread packages/microsoft_defender_endpoint/_dev/build/build.yml Outdated

@P1llus P1llus Sep 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bump this to 1.12?

@adriansr adriansr Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
Comment thread packages/microsoft_defender_endpoint/changelog.yml Outdated

@P1llus P1llus Sep 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a link to the github issue here

@adriansr adriansr Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
Comment thread packages/microsoft_defender_endpoint/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated

@P1llus P1llus Sep 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bump this to 1.12?

@adriansr adriansr Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
Comment thread packages/microsoft_defender_endpoint/manifest.yml Outdated

@P1llus P1llus Sep 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit unsure if we want to bump this to 7.16.0, same with the deprecation of the old one?

@adriansr adriansr Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now we will keep this set to the latest compatible version of kibana
adriansr and others added 8 commits September 30, 2021 11:22
@adriansr
Move defender_atp to new package microsoft_defender_endpoint
a68030c 
Moves the microsoft.defender_atp datastream into a new package:
microsoft_defender_endpoint.

This new package is GA.

Relates #1562
@adriansr
Fix
87fd9a7
@adriansr
Disable file by default
02cf5d4
@adriansr
WIP
dfdd8bf
@adriansr @leehinman
Copy system tests from #1765
c96ccb1 
Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
@adriansr
Revert "GA Microsoft Defender integration (#1765)"
9f398f9 
This reverts commit 0780419.
@adriansr
Update ECS references to 1.12
d32f139
@adriansr
Correct PR link
42bd7a2
@adriansr
adriansr requested a review from P1llus September 30, 2021 10:35
leehinman
leehinman approved these changes Sep 30, 2021
View reviewed changes

@leehinman leehinman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.
@adriansr
adriansr merged commit 966e59f into elastic:master Sep 30, 2021
@adriansr adriansr mentioned this pull request Oct 1, 2021
Merged
@adriansr adriansr mentioned this pull request Oct 18, 2021
Closed
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@adriansr @leehinman
Move defender_atp to new GA package microsoft_defender_endpoint (elas…
6f9df85 
…tic#1777)

- Moves the microsoft.defender_atp datastream into a new package:
  microsoft_defender_endpoint. This new package is GA.

- Reverts changes added by elastic#1765 as we're planning to deprecate 
  the microsoft package.

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Integration Issue or pull request for creating a new integration package.

4 participants

@adriansr @elasticmachine @P1llus @leehinman