Skip to content

[Cisco Ise] Correct guest pipeline to process guest user names - #18107

Merged
robester0403 merged 3 commits into
elastic:mainfrom
robester0403:cisco-ise-fix-guestname-processor
Mar 31, 2026
Merged

[Cisco Ise] Correct guest pipeline to process guest user names#18107
robester0403 merged 3 commits into
elastic:mainfrom
robester0403:cisco-ise-fix-guestname-processor

Conversation

@robester0403

@robester0403 robester0403 commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

Fix the processing of guest usernames in guest pipelines

image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices
@robester0403 robester0403 self-assigned this Mar 27, 2026
@robester0403 robester0403 added Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] bugfix Pull request that fixes a bug issue labels Mar 27, 2026
@robester0403 robester0403 changed the title Fix: Correct guest pipeline to process guest user names, clean up dow… Mar 27, 2026
@robester0403
robester0403 marked this pull request as ready for review March 27, 2026 23:51
@robester0403
robester0403 requested a review from a team as a code owner March 27, 2026 23:51
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@robester0403 robester0403 changed the title [Cisco Ise] Correcte guest pipeline to process guest user names Mar 30, 2026
Comment thread packages/cisco_ise/changelog.yml Outdated
# newer versions go on top
- version: "1.32.2"
changes:
- description: Fixed processing issue in guest pipeline for guestuser name.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording typo in the changelog entry: guestuser name should likely be guest user name for readability and consistency in release notes.

tag: rename_cisco_ise_log_log_details_UserName_to_user_name_d9fe4749
field: cisco_ise.log.log_details.UserName
target_field: user.name
if: ctx.user?.name == null

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cisco_ise.log.guest.user.name is populated before the fallback rename from log_details.UserName, so when only UserName is present, user.name gets set later but cisco_ise.log.guest.user.name remains unset. Consider moving the set ... copy_from: user.name step after this fallback rename (or adding a second conditional set) so both username variants consistently populate the guest user field.

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @robester0403

@robester0403
robester0403 merged commit 2167566 into elastic:main Mar 31, 2026
10 checks passed
@robester0403
robester0403 deleted the cisco-ise-fix-guestname-processor branch March 31, 2026 16:03
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.32.2 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.32.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

3 participants