Skip to content

[Watchguard_firebox] Bugfix, traffic pipeline returns errors when log.duration has seconds suffix - #18212

Merged
taylor-swanson merged 5 commits into
elastic:mainfrom
eset-122346:main
Apr 6, 2026
Merged

[Watchguard_firebox] Bugfix, traffic pipeline returns errors when log.duration has seconds suffix#18212
taylor-swanson merged 5 commits into
elastic:mainfrom
eset-122346:main

Conversation

@eset-122346

@eset-122346 eset-122346 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

WHAT:

A grok processor was added to the pipeline_traffic.yml ingest pipeline, inserted immediately before the existing convert processor for watchguard_firebox.log.duration. The new grok step uses the pattern %{NUMBER:watchguard_firebox.log.duration} to extract only the numeric value from the field, stripping any trailing non-numeric text. The changelog was updated with a 1.6.3 bugfix entry and the package version in manifest.yml was bumped from 1.6.2 to 1.6.3.

WHY:

Some WatchGuard Firebox traffic logs emit the log.duration field with a " seconds" suffix (e.g. "30 seconds" instead of "30"). The pipeline's existing convert processor (type: long) would fail on these values because it cannot parse a string containing non-numeric characters. When that happened, the on_failure handler removed the duration field entirely, losing the data, and appended an error message. By prepending a grok extraction step that isolates the numeric portion, the convert-to-long step now receives a clean number regardless of whether the source data includes the suffix, preserving the duration value in all cases without breaking the downstream seconds-to-nanoseconds conversion script.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices
@eset-122346
eset-122346 requested a review from a team as a code owner April 3, 2026 07:51
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Reviewers

Buildkite won't run for external contributors automatically; you need to add a comment:

  • /test : will kick off a build in Buildkite.

NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details.

@eset-122346 eset-122346 changed the title [bugfix] Watchguard_firebox, traffic pipeline returns errors when log.duration has seconds prefix Apr 3, 2026
@andrewkroh andrewkroh added Integration:watchguard_firebox WatchGuard Firebox Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Apr 3, 2026
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@taylor-swanson taylor-swanson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a pipeline test to show the new processor works, and as a regression test going forward?

@eset-122346

Copy link
Copy Markdown
Contributor Author

Could you add a pipeline test to show the new processor works, and as a regression test going forward?

Done.

@taylor-swanson

Copy link
Copy Markdown
Contributor

/test

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

@eset-122346 eset-122346 changed the title [Watchguard_firebox] Bugfix, traffic pipeline returns errors when log.duration has seconds prefix Apr 3, 2026
@taylor-swanson
taylor-swanson merged commit 76ff7f6 into elastic:main Apr 6, 2026
8 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package watchguard_firebox - 1.6.3 containing this change is available at https://epr.elastic.co/package/watchguard_firebox/1.6.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:watchguard_firebox WatchGuard Firebox Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

4 participants