[Watchguard_firebox] Bugfix, traffic pipeline returns errors when log.duration has seconds suffix - #18212
Merged
Conversation
Contributor
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
taylor-swanson
left a comment
Contributor
There was a problem hiding this comment.
Could you add a pipeline test to show the new processor works, and as a regression test going forward?
Contributor
Author
Done. |
Contributor
|
/test |
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
4 tasks
taylor-swanson
approved these changes
Apr 6, 2026
Contributor
|
Package watchguard_firebox - 1.6.3 containing this change is available at https://epr.elastic.co/package/watchguard_firebox/1.6.3/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT:
A grok processor was added to the pipeline_traffic.yml ingest pipeline, inserted immediately before the existing convert processor for watchguard_firebox.log.duration. The new grok step uses the pattern %{NUMBER:watchguard_firebox.log.duration} to extract only the numeric value from the field, stripping any trailing non-numeric text. The changelog was updated with a 1.6.3 bugfix entry and the package version in manifest.yml was bumped from 1.6.2 to 1.6.3.
WHY:
Some WatchGuard Firebox traffic logs emit the log.duration field with a " seconds" suffix (e.g. "30 seconds" instead of "30"). The pipeline's existing convert processor (type: long) would fail on these values because it cannot parse a string containing non-numeric characters. When that happened, the on_failure handler removed the duration field entirely, losing the data, and appended an error message. By prepending a grok extraction step that isolates the numeric portion, the convert-to-long step now receives a clean number regardless of whether the source data includes the suffix, preserving the duration value in all cases without breaking the downstream seconds-to-nanoseconds conversion script.
Checklist
changelog.ymlfile.