[Atlassian Confluence] Add agentless support - #18516
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
| template_path: httpjson.yml.hbs | ||
| vars: | ||
| - name: api_url |
There was a problem hiding this comment.
🟡 Medium audit/manifest.yml:52
Removing enabled: false from the httpjson input causes it to default to enabled alongside the logfile input. Since api_url is required with no default, users who only want logfile collection will have an enabled httpjson input lacking required configuration, causing agent errors. The sibling Atlassian integrations (atlassian_jira, atlassian_bitbucket) retain enabled: false on their httpjson streams, suggesting this removal is inconsistent with the established pattern. Consider restoring enabled: false to keep httpjson opt-in.
- input: httpjson
title: Confluence audit logs via Confluence audit API
description: Collect Confluence audit logs via Confluence audit API
+ enabled: false
template_path: httpjson.yml.hbs🤖 Copy this AI Prompt to have your agent fix this:
In file packages/atlassian_confluence/data_stream/audit/manifest.yml around lines 52-54:
Removing `enabled: false` from the `httpjson` input causes it to default to enabled alongside the `logfile` input. Since `api_url` is required with no default, users who only want logfile collection will have an enabled httpjson input lacking required configuration, causing agent errors. The sibling Atlassian integrations (`atlassian_jira`, `atlassian_bitbucket`) retain `enabled: false` on their httpjson streams, suggesting this removal is inconsistent with the established pattern. Consider restoring `enabled: false` to keep httpjson opt-in.
🚀 Benchmarks reportTo see the full report comment with |
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
kcreddy
left a comment
There was a problem hiding this comment.
Waiting on clarification for path forward: #18141 (comment) and elastic/kibana#265106 (comment)
|
/test |
| description: Collect Confluence audit logs via Confluence audit API | ||
| enabled: false | ||
| template_path: httpjson.yml.hbs | ||
| enabled: false |
There was a problem hiding this comment.
Revert this placement to the original location to avoid the diff noise.
There was a problem hiding this comment.
@moxarth-rathod this is still not done - it shows up in the diff.
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
|
Package atlassian_confluence - 1.31.0 containing this change is available at https://epr.elastic.co/package/atlassian_confluence/1.31.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues