EntityAnalytics Entra ID: add support for ECS entity fields - #18621
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
| for (def owner : ctx.device.registered_owners) { | ||
| def entry = new HashMap(); | ||
| def userObj = new HashMap(); | ||
| if (owner?.id != null) userObj.put("id", owner.id); |
There was a problem hiding this comment.
We can short circuit this by checking owner == null and continuing if it is.
Prefer not to use un-braced if.
There was a problem hiding this comment.
This entire processor has been removed at 5a42108.
| if (ctx.user == null) ctx.user = new HashMap(); | ||
| if (ctx.user.entity == null) ctx.user.entity = new HashMap(); | ||
| if (ctx.user.entity.relationships == null) ctx.user.entity.relationships = new HashMap(); |
There was a problem hiding this comment.
| if (ctx.user == null) ctx.user = new HashMap(); | |
| if (ctx.user.entity == null) ctx.user.entity = new HashMap(); | |
| if (ctx.user.entity.relationships == null) ctx.user.entity.relationships = new HashMap(); | |
| ctx.user = ctx.user ?: [:]; | |
| ctx.user.entity = ctx.user.entity ?: [:]; | |
| ctx.user.entity.relationships = ctx.user.entity.relationships ?: [:]; |
(similar above)
| source: | | ||
| def supervises = new ArrayList(); | ||
| for (def report : ctx.entityanalytics_entra_id.user.direct_reports) { | ||
| def entry = new HashMap(); |
There was a problem hiding this comment.
Similar comments here and below.
|
The origin of the test inputs should be described in the commit message. |
|
/test |
This comment has been minimized.
This comment has been minimized.
TL;DRThe failed Buildkite job is a docs/fields consistency failure, not a runtime pipeline bug. The PR moved supervisor email to Remediation
Investigation detailsRoot Cause
Evidence
Verification
Follow-upAfter regenerating docs, check for any other renamed nested relationship fields to avoid repeated README drift failures in subsequent PRs. Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
💚 Build Succeeded
History
|
|
@chemamartinez I don't see as part of this pr assignment of user.entity.relationships.administers, is it something we can't infer on the integration level? |
|
@alexreal1314 for this integration, it was populated at first but that change was reverted at 5a42108, as the most similar field at the source was the owner of the entity. After some discussions, we decided to revert it as the field specifies only administration relationships (not ownership) should be included here. |
|
Package entityanalytics_entra_id - 1.10.0 containing this change is available at https://epr.elastic.co/package/entityanalytics_entra_id/1.10.0/ |
Proposed commit message
Warning
It cannot be merged until 9.4.0 is released.
Checklist
changelog.ymlfile.Related issues