packages/aws/data_stream/config: guard against null API response fields - #18787
Merged
Conversation
The CEL program calls size() on body.EvaluationResults after checking has(), but has() returns true when the field is present with a JSON null value. size(null) has no overload, producing a runtime error that propagates to the ternary operator as "no such overload". Add != null guards to all three has()+size() patterns in the program (EvaluationResults and ConfigRules). Remove dead .orValue([]) on the map call since the true branch already guarantees a non-empty list. Update the test input to return null instead of an empty array for one rule so the fix is exercised by system tests.
efd6
force-pushed
the
aws_config_null_results
branch
from
May 4, 2026 23:24
932a81e to
8b84c4a
Compare
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
efd6
marked this pull request as ready for review
May 5, 2026 01:48
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
5 tasks
Contributor
|
Package aws - 6.14.1 containing this change is available at https://epr.elastic.co/package/aws/6.14.1/ |
herrBez
pushed a commit
to herrBez/integrations
that referenced
this pull request
Jun 1, 2026
…ds (elastic#18787) The CEL program calls size() on body.EvaluationResults after checking has(), but has() returns true when the field is present with a JSON null value. size(null) has no overload, producing a runtime error that propagates to the ternary operator as "no such overload". Add != null guards to all three has()+size() patterns in the program (EvaluationResults and ConfigRules). Remove dead .orValue([]) on the map call since the true branch already guarantees a non-empty list. Update the test input to return null instead of an empty array for one rule so the fix is exercised by system tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots